Adds upgrade guide to Bamboo 2.0 #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What changed? ============ This adds an upgrade guide for migrating to Bamboo 2.0. At its core, there are only two breaking changes: `bamboo_phoenix` being extracted and the new usage of `Mailer.deliver_now` & `Mailer.deliver_later` functions.
germsvel
commented
Feb 19, 2021
| [adapter.deliver callback]: https://hexdocs.pm/bamboo/2.0.0/Bamboo.Adapter.html#c:deliver/2 | ||
| [delivery strategy]: https://hexdocs.pm/bamboo/2.0.0/Bamboo.DeliverLaterStrategy.html | ||
| [opening an issue]: https://github.com/thoughtbot/bamboo/issues | ||
| [bamboo_phoenix]: https://hexdocs.pm/bamboo_phoenix |
There was a problem hiding this comment.
Known issue: this link is not available until I publish bamboo_phoenix. And that can't happen until I publish Bamboo 2.0. But the link will work once those are published.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This adds an upgrade guide for migrating to Bamboo 2.0. At its core, there are only two breaking changes:
bamboo_phoenixbeing extracted and the new usage ofMailer.deliver_now&Mailer.deliver_laterfunctions.