Parent factory with traits that call other traits uses trait from child factory

[EmilioCristalli]

Description

Not sure if this is a bug or expected behavior, but it felt confusing to me.

I have a factory A with a trait trait_a that calls another trait trait_b.
And I have another factory B that inherits from A and overrides trait_b.

If I first use factory B, then factory A starts using trait_b from B when trait_a is called (probably more clear with the example below haha)

Reproduction Steps

require "bundler/inline"

gemfile(true) do
  source "https://rubygems.org"
  git_source(:github) { |repo| "https://github.com/#{repo}.git" }
  gem "factory_bot", "~> 6.0"
  gem "activerecord"
  gem "sqlite3"
end

require "active_record"
require "factory_bot"
require "minitest/autorun"
require "logger"

ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: ":memory:")
ActiveRecord::Base.logger = Logger.new(STDOUT)

ActiveRecord::Schema.define do
  create_table :posts, force: true do |t|
    t.string :title
    t.string :content
  end
end

class Post < ActiveRecord::Base
end

FactoryBot.define do
  factory :post do
    trait :with_title_and_content do
      with_title
      with_content
    end

    trait :with_title do
      title { "generic title" }
    end

    trait :with_content do
      content { "generic content" }
    end
  end

  factory :tech_post, parent: :post do
    trait :with_content do
      content { "tech content" }
    end
  end
end

class FactoryBotTest < Minitest::Test
  def test_factory_bot_stuff
    tech_post = FactoryBot.build(:tech_post, :with_title_and_content)
    assert_equal "generic title", tech_post.title
    assert_equal "tech content", tech_post.content

    generic_post = FactoryBot.build(:post, :with_title_and_content)
    assert_equal "generic title", generic_post.title
    assert_equal "generic content", generic_post.content
  end
end

# Run the tests with `ruby <filename>`

Expected behavior

The test should pass, because the parent factory should use the with_content trait from the parent factory

Actual behavior

It fails, because it uses the with_content trait from the child tech_post factory

FactoryBotTest#test_factory_bot_stuff [factory.rb:61]:
Expected: "generic content"
  Actual: "tech content"

System configuration

factory_bot version: 6.5.0
rails version: 7.2.1
ruby version: 3.3.5

[CodeMeister]

Hi @EmilioCristalli,

Love the reproduction steps ... made it much easier 👍

I've submitted a pull request that should fix this issue #1717

Have a look and see if it works for you?

As it's relatively small, I'd love it if you could create a new branch, merge the request (or cut/paste the changes) and run your tests. Real world tests are a far better indication of success. 🫶

[EmilioCristalli]

thanks for looking into this @CodeMeister!!

your PR seems to fix the issue for me

[CodeMeister]

Hi @EmilioCristalli. It would be best to leave this issue open until the PR is merged. Otherwise, the team may think it was fixed by another solution.

🎉

[EmilioCristalli]

lol i mentioned your PR fixes this issue in a PR to use a workaround in a private repo, and github automatically closed this issue when i merged it haha

sorry about that, will reopen it

[CodeMeister]

Hehe, GitHub works in mysterious ways...

Thanks for re-opening 👍