Skip Spring version 2.1.1

Changes introduced in spring 2.1.1
(rails/spring#621) are breaking some tests. That
change was reverted in rails/spring#629, but
hasn't been released yet. Until #629 is released, this PR skips Spring
version 2.1.1.

Co-authored-by: Daniel J. Colson <daniel.colson@hey.com>

Author: Christina Entcheva

Appraisals

@@ -4,7 +4,7 @@ appraise "rails5.0" do
   gem "listen", "~> 3.0.5"
   gem "puma", "~> 3.0"
   gem "rails", "~> 5.0.7", ">= 5.0.7.2"
-  gem "spring"
+  gem "spring", "!= 2.1.1"
   gem "spring-watcher-listen", "~> 2.0.0"
   gem "sqlite3", "~> 1.3.6"
 end
@@ -14,7 +14,7 @@ appraise "rails5.1" do
   gem "listen", ">= 3.0.5", "< 3.2"
   gem "puma", "~> 3.7"
   gem "rails", "~> 5.1.7"
-  gem "spring"
+  gem "spring", "!= 2.1.1"
   gem "spring-watcher-listen", "~> 2.0.0"
   gem "sqlite3", "~> 1.3.6"
 end
@@ -24,7 +24,7 @@ appraise "rails5.2" do
   gem "listen", ">= 3.0.5", "< 3.2"
   gem "puma", "~> 3.11"
   gem "rails", "~> 5.2.4", ">= 5.2.4.2"
-  gem "spring"
+  gem "spring", "!= 2.1.1"
   gem "spring-watcher-listen", "~> 2.0.0"
   gem "sqlite3", "~> 1.3.6"
 end
@@ -34,7 +34,7 @@ appraise "rails6.0" do
   gem "listen", "~> 3.2"
   gem "puma", "~> 4.1"
   gem "rails", "~> 6.0.2", ">= 6.0.2.2"
-  gem "spring"
+  gem "spring", "!= 2.1.1"
   gem "spring-watcher-listen", "~> 2.0.0"
   gem "sqlite3", "~> 1.4"
 end

features/reloading.feature

@@ -13,7 +13,7 @@ Feature: automatically reloading factory_bot definitions
         end
       end
       """
-    And I run `bundle exec rake db:migrate` with a clean environment
+    And I run `bin/rails db:migrate` with a clean environment
 
   Scenario: When using factory_bot_rails together with Spring
     I want changes to my application to trigger the factory_bot_rails reloader
@@ -44,14 +44,14 @@ Feature: automatically reloading factory_bot definitions
         end
       end
       """
-    And I run `bundle binstubs bundler rake spring --force` with a clean environment
+    And I run `bundle binstubs bundler spring --force` with a clean environment
     And I run `bin/spring binstub --all` with a clean environment
-    And I run `bin/rake test` with Spring enabled
+    And I run `bin/rails test` with Spring enabled
     And I append to "app/models/user.rb" with:
       """
       # User model edited
       """
-    And I run `bin/rake test` with Spring enabled
+    And I run `bin/rails test` with Spring enabled
     And I run `spring stop` with a clean environment
     Then the output should contain "1 runs, 1 assertions"
     And the output should not contain "Failure:"
@@ -70,9 +70,9 @@ Feature: automatically reloading factory_bot definitions
       # Empty definition file to be picked up by the file watcher
 
       """
-    And I run `bundle binstubs bundler rake spring --force` with a clean environment
+    And I run `bundle binstubs bundler spring --force` with a clean environment
     And I run `bin/spring binstub --all` with a clean environment
-    And I run `bin/rake test` with Spring enabled
+    And I run `bin/rails test` with Spring enabled
     And I append to "test/factories.rb" with:
       """
       FactoryBot.define do
@@ -93,7 +93,7 @@ Feature: automatically reloading factory_bot definitions
         end
       end
       """
-    And I run `bin/rake test` with Spring enabled
+    And I run `bin/rails test` with Spring enabled
     And I run `spring stop` with a clean environment
     Then the output should contain "1 runs, 1 assertions"
     And the output should not contain "Failure:"
@@ -130,6 +130,6 @@ Feature: automatically reloading factory_bot definitions
           end
         end
         """
-      And I run `bundle exec rake test` with a clean environment
+      And I run `bin/rails test` with a clean environment
       Then the output should contain "1 runs, 1 assertions"
       And the output should not contain "Failure:"

features/support/rails_template

@@ -1,3 +1,5 @@
 if Rails.gem_version < Gem::Version.new('6')
   gsub_file "Gemfile", /^gem 'sqlite3'$/, 'gem "sqlite3", "~> 1.3.6"'
 end
+
+gsub_file "Gemfile", /^ gem 'spring'$/, ' gem "spring", "!= 2.1.1"'

gemfiles/rails5.0.gemfile

@@ -12,7 +12,7 @@ gem "byebug"
 gem "listen", "~> 3.0.5"
 gem "puma", "~> 3.0"
 gem "rails", "~> 5.0.7", ">= 5.0.7.2"
-gem "spring"
+gem "spring", "!= 2.1.1"
 gem "spring-watcher-listen", "~> 2.0.0"
 gem "sqlite3", "~> 1.3.6"
 

gemfiles/rails5.1.gemfile

@@ -12,7 +12,7 @@ gem "byebug"
 gem "listen", ">= 3.0.5", "< 3.2"
 gem "puma", "~> 3.7"
 gem "rails", "~> 5.1.7"
-gem "spring"
+gem "spring", "!= 2.1.1"
 gem "spring-watcher-listen", "~> 2.0.0"
 gem "sqlite3", "~> 1.3.6"
 

gemfiles/rails5.2.gemfile

@@ -12,7 +12,7 @@ gem "byebug"
 gem "listen", ">= 3.0.5", "< 3.2"
 gem "puma", "~> 3.11"
 gem "rails", "~> 5.2.4", ">= 5.2.4.2"
-gem "spring"
+gem "spring", "!= 2.1.1"
 gem "spring-watcher-listen", "~> 2.0.0"
 gem "sqlite3", "~> 1.3.6"
 

gemfiles/rails6.0.gemfile

@@ -12,7 +12,7 @@ gem "byebug"
 gem "listen", "~> 3.2"
 gem "puma", "~> 4.1"
 gem "rails", "~> 6.0.2", ">= 6.0.2.2"
-gem "spring"
+gem "spring", "!= 2.1.1"
 gem "spring-watcher-listen", "~> 2.0.0"
 gem "sqlite3", "~> 1.4"