Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemspec problem makes boilerplate files globally executable #1179

Closed
MadBomber opened this issue Feb 25, 2019 · 2 comments
Closed

gemspec problem makes boilerplate files globally executable #1179

MadBomber opened this issue Feb 25, 2019 · 2 comments

Comments

@MadBomber
Copy link

The bin directory only contains common boilerplate files. The gemspec file those common boilerplate files in the bin directory globally executable. Delete the line in the gemspec that makes everything in the bin directory globally executable.

Delete this line:
s.executables = git ls-files -- bin/*.split("\n").map{ |f| File.basename(f) }

@mcmire
Copy link
Collaborator

mcmire commented Feb 25, 2019

Hey! Thanks for bringing this to our attention. You are 100% right and I am super embarrassed by this. I just opened #1180 to fix this. As soon as the tests pass I'll merge it and issue another release.

@mcmire
Copy link
Collaborator

mcmire commented Feb 26, 2019

I've released 4.0.1 with a correct gemspec. I've also yanked 4.0.0 so that hopefully this doesn't happen for anyone else.

@mcmire mcmire closed this as completed Feb 26, 2019
@mcmire mcmire mentioned this issue Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants