Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of PR 1180 #1181

Closed
n-rodriguez opened this issue Feb 26, 2019 · 1 comment
Closed

Review of PR 1180 #1181

n-rodriguez opened this issue Feb 26, 2019 · 1 comment

Comments

@n-rodriguez
Copy link

n-rodriguez commented Feb 26, 2019

Hi there!

I review the #1180 : I don't know if doing a chdir is a good thing here. If you wanted to remove setup you could have removed the executables method call.
See Sidekiq for example : sidekiq/sidekiq#4023

@mcmire
Copy link
Collaborator

mcmire commented Feb 26, 2019

Left a comment on your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants