Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Content Widths in Child Themes #74

Closed
douglas-johnson opened this issue Aug 2, 2021 · 1 comment · Fixed by #75
Closed

Set Content Widths in Child Themes #74

douglas-johnson opened this issue Aug 2, 2021 · 1 comment · Fixed by #75
Assignees

Comments

@douglas-johnson
Copy link
Member

Based on #73 here is my plan

  • Expand on the work in https://github.com/thoughtis/cata/tree/0.6.0-beta1 which added theme.json
  • Use variables like --wp--custom--content-size in CSS in addition to the editor.
  • Update existing block CSS to support the latest block markup in WP 5.8
    • Test whether backward compatibility is necessary.
  • In child themes
    • Set font sizes, color palette and gradients in theme.json instead of using add_theme_support
    • Update CSS to use custom properties for width where desired ( we may still need the old widths for some pages, that's OK ).
    • Update CSS for latest block markup.
@douglas-johnson douglas-johnson self-assigned this Aug 2, 2021
@douglas-johnson
Copy link
Member Author

First hiccup. Media Queries.

A few of the blocks needs them, specifically: Cover, Media-Text and Columns.

My first thought is to move the responsive bits into the child theme, is there something better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant