Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool IDs are not cached #231

Open
quoll opened this issue Mar 13, 2022 · 0 comments
Open

Pool IDs are not cached #231

quoll opened this issue Mar 13, 2022 · 0 comments

Comments

@quoll
Copy link
Contributor

quoll commented Mar 13, 2022

find-id in the pool should be heavily cached. It's not, and that's a mistake.

Note that the pool only grows, so there is no need to cache by the pool root. However, if it ever returns nil then don't cache it, since the pool may have expanded. (or remember that the nil came from a pool root id)

The same should happen for find-object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant