Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Valid Git Directory by Comparing Top-Level Path #73

Open
threeal opened this issue Apr 30, 2024 · 0 comments · May be fixed by #74
Open

Check Valid Git Directory by Comparing Top-Level Path #73

threeal opened this issue Apr 30, 2024 · 0 comments · May be fixed by #74
Assignees
Milestone

Comments

@threeal
Copy link
Owner

threeal commented Apr 30, 2024

This issue suggests modifying how to check if a directory contains a Git repository by comparing the Git top-level path with the directory path. This change is proposed because merely checking the Git status or if a path is inside a Git directory is not sufficient. Since this project itself is within a Git repository, any directory or files within this project will be considered inside a Git directory. Therefore, comparing the top-level paths is a better approach to determine whether a directory contains a Git repository or not.

@threeal threeal added this to the Version 1.1.0 milestone Apr 30, 2024
@threeal threeal self-assigned this Apr 30, 2024
@threeal threeal added this to Granary Apr 30, 2024
@threeal threeal linked a pull request Apr 30, 2024 that will close this issue
3 tasks
@threeal threeal moved this to Not Harvestable in Granary May 3, 2024
@threeal threeal removed this from Granary May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant