Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Flow in getCacheKey Function #167

Closed
threeal opened this issue Feb 20, 2024 · 0 comments · Fixed by #168
Closed

Refactor Flow in getCacheKey Function #167

threeal opened this issue Feb 20, 2024 · 0 comments · Fixed by #168
Assignees
@threeal
Labels
refactor
Milestone
Version 2.0.0

Comments

@threeal
Copy link
Owner

threeal commented Feb 20, 2024

This issue suggests refactoring the following flow in the getCacheKey function by simplifying the if condition for constructing the cache key if a lock file does not exist in the project:

https://github.com/threeal/yarn-install-action/blob/9eb826cd9068cdd1ef5b89ff4e232b6febab685c/src/cache.ts#L11-L23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@threeal threeal

Labels
refactor
Projects
None yet
Milestone
Version 2.0.0
Development

Successfully merging a pull request may close this issue.

Refactor Flow in getCacheKey Function threeal/setup-yarn-action
1 participant
@threeal