Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

books html page #8

Open
kwlskiy opened this issue Oct 20, 2020 · 4 comments · May be fixed by #45
Open

books html page #8

kwlskiy opened this issue Oct 20, 2020 · 4 comments · May be fixed by #45
Assignees
@mshinh
Labels
css CSS easy An easy Issue to implement frontend React environment html HTML task Small step to contribute to the system!

Comments

@kwlskiy
Copy link
Contributor

kwlskiy commented Oct 20, 2020 •
edited
Loading

  • Add a "books.html" that contains 3 "pseudo books", it should contain a list of books with a cover, the goal is it to be like the "Main Section 1" on the picture, does not need to be responsive, follow the wireframe prototype.
  • Add sytling to the "books.html", it needs to be in line with "theme.md"
  • Make books responsive with SCSS/CSS
@kwlskiy kwlskiy added frontend React environment easy An easy Issue to implement task Small step to contribute to the system! html HTML css CSS labels Oct 20, 2020
@kwlskiy kwlskiy changed the title Books html books html page Oct 20, 2020
@mshinh
Copy link
Contributor

mshinh commented Oct 26, 2020

Hey, I'd like to work on this issue. Can you assign it to me?

@kwlskiy
Copy link
Contributor Author

kwlskiy commented Oct 27, 2020

done

@mshinh
Copy link
Contributor

mshinh commented Oct 28, 2020 •
edited
Loading

I have forked the repo and cloned it. For clarity, which main section 1? As I see, the current state has a list of books so you want a separate html file looking like that?
From what I see comparing the mockups/wireframe and the current design, I think that the book Info page is the one that needs improvement in styling. Assuming this, Im gonna work on that.
So, let me know what you think. Thanks

@mshinh
Copy link
Contributor

mshinh commented Oct 28, 2020

I have updated the style of book info page, i.e. the page that shows the book details when the user clicks on a book from the list on the landing page.
Submitted PR. Please review and let me know.
Thanks

@mshinh mshinh linked a pull request Oct 28, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mshinh mshinh

Labels
css CSS easy An easy Issue to implement frontend React environment html HTML task Small step to contribute to the system!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix styling of book info page mshinh/3dev-fullstack
2 participants
@kwlskiy @mshinh