Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Directories #82

Open
Mik-TF opened this issue Oct 17, 2024 · 4 comments
Open

Rename Directories #82

Mik-TF opened this issue Oct 17, 2024 · 4 comments
Assignees

Comments

@Mik-TF
Copy link
Contributor

Mik-TF commented Oct 17, 2024

Situation

  • The TFGrid Full Stack deployment procedures and documentation are completed
  • We could make sure that the repo is as clear as possible for newcomers
  • grid-hub contains both the hub and bootstrap content
  • docker-compose folder contains the grid backend content

TODO

Can we:

  • rename grid-hub to grid-hub-bootstrap
  • rename docker-compose to grid-backend

I ask instead of doing it directly, in case it affects any scripts/procedures created.

Notes

  • Once we agree on a process, I can do the changes necessary in a PR and you review the work @coesensbert
@coesensbert
Copy link
Contributor

yea sure that would be better, the only thing I don't know is what happens to where this repo is already synced. Each deployment we have has this repo cloned, and has some custom modifications in it's .secrets.env file. I'm not sure what happens to this file if we rename the directory. So to avoid having issues with our production deployments.
Apart from that, let's change it yes

@Mik-TF
Copy link
Contributor Author

Mik-TF commented Oct 18, 2024

OK good. Then I will make a draft PR with the changes and we check how to proceed further. Thanks.

@coesensbert
Copy link
Contributor

checked with dev, can be done. Will test it first

@Mik-TF
Copy link
Contributor Author

Mik-TF commented Oct 21, 2024

Nice! Thanks and good collaboration between ops and devs 🚀 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants