Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alert_raise should always have the traceback #1639

Closed
xmonader opened this issue Nov 8, 2020 · 2 comments
Closed

alert_raise should always have the traceback #1639

xmonader opened this issue Nov 8, 2020 · 2 comments
Assignees
@ranatrk @hossnys
Labels
priority_major
Milestone
now

Comments

@xmonader
Copy link
Collaborator

xmonader commented Nov 8, 2020

noticed in deployer and chatflows that we raise alerts without having tracebacks
@xmonader xmonader added this to the now milestone Nov 8, 2020
@ranatrk ranatrk self-assigned this Nov 8, 2020
This was referenced Nov 9, 2020
Merged
Merged
@ranatrk
Copy link
Contributor

ranatrk commented Nov 11, 2020

Merge waiting on next release for js-ng changes to be able to use the changes in js-sdk chatflows

@hossnys hossnys self-assigned this Nov 15, 2020
@hossnys
Copy link
Contributor

hossnys commented Nov 15, 2020

verified on development branch , traceback is now included in the alerts raised .

Screenshot from 2020-11-15 16-53-39

@hossnys hossnys closed this as completed Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ranatrk ranatrk

@hossnys hossnys

Labels
priority_major
Projects
None yet
Milestone
now
Development

No branches or pull requests
3 participants
@xmonader @ranatrk @hossnys