Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mycelium integration in zos grid go client #677

Closed
Tracked by #1480
muhamadazmy opened this issue Jan 29, 2024 · 1 comment
Closed
Tracked by #1480

mycelium integration in zos grid go client #677

muhamadazmy opened this issue Jan 29, 2024 · 1 comment
Assignees
Labels
grid-client belongs to grid client type_feature New feature or request

Comments

@muhamadazmy
Copy link
Member

Is your feature request related to a problem? Please describe

Right now, we are adding support for mycelium in zos. this will require some changes to the go client to support this new feature.

ZOS consider mycelium as an optional feature, which means older clients can still work but not be able to use this feature without breaking.

Describe the solution you'd like

The mycelium feature is used in 2 parts:

  • It has to be configured in the network itself as defined here
  • This setup if provided enable mycelium for this network on this node. The seed provided has to be unique and valid. Has to be 32 bytes and encoded as hex in the json body.
  • Once the network mycelium was set up. We can now enable it per VM that is part of this network as here
@muhamadazmy muhamadazmy added the type_feature New feature or request label Jan 29, 2024
@muhamadazmy muhamadazmy moved this to Blocked in 3.13.x Jan 29, 2024
@rawdaGastan rawdaGastan added the grid-client belongs to grid client label Jan 29, 2024
@muhamadazmy muhamadazmy moved this from Blocked to Accepted in 3.13.x Jan 31, 2024
@AbdelrahmanElawady AbdelrahmanElawady self-assigned this Jan 31, 2024
@ramezsaeed ramezsaeed added this to the 1.0.0 milestone Jan 31, 2024
@AbdelrahmanElawady AbdelrahmanElawady moved this from Accepted to Pending review in 3.13.x Jan 31, 2024
@AbdelrahmanElawady AbdelrahmanElawady moved this from Pending review to In Verification in 3.13.x Jan 31, 2024
@Eslam-Nawara
Copy link
Contributor

Eslam-Nawara commented Mar 3, 2024

Verified:
tried deploying vm with random mycelium ip seed on a network with random mycelium key and returned mycelium ip successfully and was able to connect the vm using mycelium ip.

➜  test-go go run *.go
2024/03/03 16:27:16 mnemonics: ***
2024/03/03 16:27:16 network: dev
4:27PM INF starting peer session=tf-76091 twin=4653
name: vm
flist: https://hub.grid.tf/tf-official-apps/base:latest.flist
flistchecksum: ""
publicip: false
publicip6: false
planetary: false
corex: false
computedip: ""
computedip6: ""
planetaryip: ""
myceliumip: 5f6:bb70:c17:1c50:ff0f:b143:e764:3009
ip: 10.20.2.2
myceliumipseed:
    - 177
    - 67
    - 231
    - 100
    - 48
    - 9
description: ""
gpus: []
cpu: 2
memory: 1024
rootfssize: 0
entrypoint: /sbin/zinit init
mounts: []
zlogs: []
envvars:
    SSH_KEY: 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQCjGsz8evMP5F4jh3FI9cAJb1HxXtwObR+Yqz/1HPDXHL8El9fDsfpiKjLvfvb3LesMPeo4Sttda+u/ytaOM8aIU6p45dSDqphkDdplWZGk4iz+KGO/1UyvVhF09oiFbYh8qAm2eWUal6cufDtCnisDz3RDNpjK1uSmcQ/hdWiTWi2wRgBx8TseZDCDzuD14rPKaPlJg7I6NIhGaxRaN39ti6FsW3udi3eIA4VYl8QBswwLf0o3JLAwCPgOyH63Hc5WEE6e9ofP9b1cw6ZUwLuuINWWWysLo9/WHMbVWDuQEOybxz6qJHgZ8KVURh2GQqSxeZyCxZGOJlrNgt4sKdI8Hgs5hodZabp1SZUbpOnH5ujzD7KahwUhF/+EZPd8/+FouKsWsnkrM+g6q6rOHtdBZ0QEwDpXy6I6PVEkRaNNtnmEme+IsJBLgcmRms7h8xzjj0touV674xPiNu393uXvu9qtoxtZlYdeeh4VtaX+4xVsxXu20HGgGWEzilEJTik= eslam@eslam-Inspiron-3576 '
networkname: vmTestingNetwork
consoleurl: 10.20.2.0:20002

➜  test-go ping6 5f6:bb70:c17:1c50:ff0f:b143:e764:3009
PING 5f6:bb70:c17:1c50:ff0f:b143:e764:3009(5f6:bb70:c17:1c50:ff0f:b143:e764:3009) 56 data bytes
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=1 ttl=60 time=139 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=2 ttl=60 time=164 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=3 ttl=60 time=186 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=4 ttl=60 time=209 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=5 ttl=60 time=232 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=6 ttl=60 time=254 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=7 ttl=60 time=282 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=8 ttl=60 time=306 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=9 ttl=60 time=329 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=10 ttl=60 time=139 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=11 ttl=60 time=168 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=12 ttl=60 time=187 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=13 ttl=60 time=209 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=14 ttl=60 time=232 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=15 ttl=60 time=254 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=16 ttl=60 time=283 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=17 ttl=60 time=299 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=18 ttl=60 time=343 ms
64 bytes from 5f6:bb70:c17:1c50:ff0f:b143:e764:3009: icmp_seq=19 ttl=60 time=142 ms
^C
--- 5f6:bb70:c17:1c50:ff0f:b143:e764:3009 ping statistics ---
22 packets transmitted, 19 received, 13.6364% packet loss, time 21072ms
rtt min/avg/max/mdev = 138.611/229.235/342.975/63.662 ms

@Eslam-Nawara Eslam-Nawara moved this from In Verification to Done in 3.13.x Mar 3, 2024
@rawdaGastan rawdaGastan modified the milestones: 1.0.0, v0.13.x - v0.14.x Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid-client belongs to grid client type_feature New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants