Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: check the node region filter #699

Closed
Omarabdul3ziz opened this issue Jan 30, 2024 · 2 comments
Closed

🐞 [Bug]: check the node region filter #699

Omarabdul3ziz opened this issue Jan 30, 2024 · 2 comments
Assignees
Labels
grid-proxy belongs to grid proxy type_bug Something isn't working
Milestone

Comments

@Omarabdul3ziz
Copy link
Contributor

What happened?

calling this: https://gridproxy.grid.tf/nodes?country=United%20States returns some nodes
but adding the region filter: https://gridproxy.grid.tf/nodes?country=United%20States&region=Americas returns none, it should not be affected.
also: https://gridproxy.grid.tf/nodes?region=Americas&size=1000 didn't return any united-stated country

this looks with those three countries: United States, United Kingdom, Czechia.

it maybe conflict on the data and the nodes has conflicts on the names: United States of America, United Kingdom of Great Britain and Northern Ireland, Czech Republic

which network/s did you face the problem on?

Main

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant log output

none
@Omarabdul3ziz Omarabdul3ziz added type_bug Something isn't working grid-proxy belongs to grid proxy labels Jan 30, 2024
@Omarabdul3ziz Omarabdul3ziz moved this to Accepted in 3.13.x Jan 30, 2024
@Omarabdul3ziz Omarabdul3ziz added this to the 1.0.0 milestone Jan 30, 2024
@Omarabdul3ziz Omarabdul3ziz moved this from Accepted to In Progress in 3.13.x Feb 20, 2024
@Omarabdul3ziz Omarabdul3ziz self-assigned this Feb 20, 2024
@Omarabdul3ziz
Copy link
Contributor Author

there is already an open issue for the original cause of this on the graphql repo. i commented the findings there threefoldtech/tfchain_graphql#148 (comment)

we can still handle this on the proxy by replacing the exact matching with like

LEFT JOIN country ON LOWER(node.country) = LOWER(country.name)

but i think it is better to be handled from graphql

@Omarabdul3ziz Omarabdul3ziz moved this from In Progress to Blocked in 3.13.x Feb 20, 2024
@xmonader xmonader removed this from 3.13.x Feb 26, 2024
@xmonader xmonader added this to 3.14.x Feb 26, 2024
@Omarabdul3ziz
Copy link
Contributor Author

the countries names are fixed in the graphql
image

and the region filter works fine now
image

@Omarabdul3ziz Omarabdul3ziz moved this to In Verification in 3.14.x Mar 3, 2024
@github-project-automation github-project-automation bot moved this from In Verification to Done in 3.14.x Jun 10, 2024
@rawdaGastan rawdaGastan modified the milestones: 1.0.0, v0.15.x Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid-proxy belongs to grid proxy type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants