Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update health indexer to use zos.system.diagnostics #891

Closed
Omarabdul3ziz opened this issue Mar 3, 2024 · 1 comment
Closed

update health indexer to use zos.system.diagnostics #891

Omarabdul3ziz opened this issue Mar 3, 2024 · 1 comment
Assignees
@Omarabdul3ziz
Labels
grid-proxy belongs to grid proxy type_feature New feature or request
Milestone
v0.16.x

Comments

@Omarabdul3ziz
Copy link
Contributor

Is your feature request related to a problem? Please describe

currently, we decide if the node is healthy or not based on just its response of the rmb call zos.system.version

Describe the solution you'd like

we can use the call zos.system.diagnostics instead, and make the node health depend on the SystemOk in the response
@Omarabdul3ziz Omarabdul3ziz added the type_feature New feature or request label Mar 3, 2024
@Omarabdul3ziz Omarabdul3ziz added this to the 1.0.0 milestone Mar 3, 2024
@Omarabdul3ziz Omarabdul3ziz added the grid-proxy belongs to grid proxy label Mar 3, 2024
This was referenced Mar 27, 2024
Closed
Merged
@Omarabdul3ziz Omarabdul3ziz moved this to Pending Review in 3.14.x Mar 27, 2024
@Omarabdul3ziz Omarabdul3ziz self-assigned this Mar 27, 2024
@xmonader xmonader changed the title better decision for node health update health indexer to use zos.system.diagnostics Mar 28, 2024
@Omarabdul3ziz Omarabdul3ziz moved this from Pending Review to Blocked in 3.14.x May 15, 2024
@Omarabdul3ziz Omarabdul3ziz moved this from Blocked to Pending Deployment in 3.14.x Jun 4, 2024
@xmonader xmonader added this to 3.15.x Aug 1, 2024
@xmonader xmonader removed this from 3.14.x Aug 1, 2024
@xmonader xmonader moved this to Accepted in 3.15.x Aug 1, 2024
@xmonader xmonader moved this from Accepted to In Progress in 3.15.x Aug 1, 2024
@Omarabdul3ziz Omarabdul3ziz moved this from In Progress to Pending Deployment in 3.15.x Aug 18, 2024
@Omarabdul3ziz Omarabdul3ziz moved this from Pending Deployment to In Verification in 3.15.x Sep 3, 2024
@rawdaGastan rawdaGastan modified the milestones: 1.0.0, v0.16.0 Sep 25, 2024
@rawdaGastan
Copy link
Collaborator

rawdaGastan commented Oct 28, 2024 •
edited
Loading

Verification

  • zos.system.version isn't used now and zos.system.diagnostics is used instead

@github-project-automation github-project-automation bot moved this from In Verification to Done in 3.15.x Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Omarabdul3ziz Omarabdul3ziz

Labels
grid-proxy belongs to grid proxy type_feature New feature or request
Projects
3.15.x
Status: Done
Milestone
v0.16.x
Development

No branches or pull requests
2 participants
@Omarabdul3ziz @rawdaGastan