Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the UI package on npm, create v server for the verification #1542

Closed
Mahmoud-Emad opened this issue Nov 29, 2023 · 5 comments
Closed
Assignees
Labels
documentation request for documentation improvement UI
Milestone

Comments

@Mahmoud-Emad
Copy link
Contributor

Mahmoud-Emad commented Nov 29, 2023

No description provided.

@Mahmoud-Emad Mahmoud-Emad self-assigned this Nov 29, 2023
@Mahmoud-Emad Mahmoud-Emad added documentation request for documentation improvement UI labels Nov 29, 2023
@Mahmoud-Emad Mahmoud-Emad moved this to In Progress in 3.12.x Nov 29, 2023
@Mahmoud-Emad Mahmoud-Emad added this to the 2.2.0 milestone Nov 29, 2023
@Mahmoud-Emad
Copy link
Contributor Author

Should be implemented in #1541

@Mahmoud-Emad Mahmoud-Emad moved this from In Progress to In Verification in 3.12.x Nov 29, 2023
@A-Harby
Copy link
Contributor

A-Harby commented Dec 4, 2023

I keep getting this error when I run the Node.js example server, despite running yarn install and build.
image

And can you also add documents for the vlang server, or just make the Node.js server work for both of them?

@Mahmoud-Emad
Copy link
Contributor Author

@A-Harby

Hello Harby 😊,

Addressing the first point, it seems like there might be a dependency error. Kindly verify the successful installation of the cors package by checking the node_modules folder.

Regarding the second point, the v server is intended to replicate the behavior of the Node server without verification. It simply logs the request payload. To enhance clarity, I'll update the server documentation with step-by-step instructions on how to run it. thanks for bringing these points to my attention. I'll get to work on the updates.

@Mahmoud-Emad
Copy link
Contributor Author

Update:

The requested changes in the server docs should be done in #1548

@Mahmoud-Emad Mahmoud-Emad moved this from In Verification to In Progress in 3.12.x Dec 4, 2023
@A-Harby
Copy link
Contributor

A-Harby commented Dec 4, 2023

Yes, the nodejs error was from my npm, and after I updated it, it worked fine.

@A-Harby

Hello Harby 😊,

Addressing the first point, it seems like there might be a dependency error. Kindly verify the successful installation of the cors package by checking the node_modules folder.

@AhmedHanafy725 AhmedHanafy725 moved this from In Progress to In Verification in 3.12.x Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation request for documentation improvement UI
Projects
No open projects
Status: In Verification
Development

No branches or pull requests

3 participants