Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset nodes table count and pages #1604

Closed
A-Harby opened this issue Dec 7, 2023 · 7 comments
Closed

Reset nodes table count and pages #1604

A-Harby opened this issue Dec 7, 2023 · 7 comments
Assignees
Labels
dashboard type_bug Something isn't working
Milestone

Comments

@A-Harby
Copy link
Contributor

A-Harby commented Dec 7, 2023

Description

Devnet, 2d54818.

Filtering, applying toggles, or selecting the node status doesn't reset table counts or disable page navigation on it.

Steps to reproduce

  1. Connect your wallet.
  2. Navigate to the Nodes page from the sidebar.
  3. Click on any node and scroll down to the Twin Details section.

Logs/Alerts

image

Threefold.Dashboard._.Nodes.webm
@A-Harby A-Harby added type_bug Something isn't working dashboard labels Dec 7, 2023
@ramezsaeed ramezsaeed added this to the 2.3.0 milestone Dec 11, 2023
@zaelgohary zaelgohary moved this to Accepted in 3.13.x Dec 11, 2023
@mohamedamer453 mohamedamer453 self-assigned this Dec 12, 2023
@mohamedamer453 mohamedamer453 moved this from Accepted to In Progress in 3.13.x Dec 12, 2023
@mohamedamer453
Copy link
Contributor

Update

Work in Progress(WIP):

Still under investigation, trying to find out how to update the item-length property when the status change and there're no nodes available since this is the scenario where it displays the number from the previous table while there are no nodes available.

@mohamedamer453 mohamedamer453 moved this from In Progress to Pending review in 3.13.x Dec 13, 2023
@mohamedamer453 mohamedamer453 moved this from Pending review to In Verification in 3.13.x Dec 13, 2023
@A-Harby
Copy link
Contributor Author

A-Harby commented Dec 20, 2023

Not all the cases have been reset.

Threefold.Dashboard._.Nodes.1.webm

@A-Harby A-Harby moved this from In Verification to In Progress in 3.13.x Dec 20, 2023
@zaelgohary zaelgohary moved this from In Progress to Accepted in 3.13.x Dec 20, 2023
@amiraabouhadid amiraabouhadid moved this from Accepted to In Progress in 3.13.x Dec 21, 2023
@amiraabouhadid
Copy link
Contributor

Investigative Work:
Looked for the reset triggers in nodes.vue

@amiraabouhadid amiraabouhadid moved this from In Progress to Pending review in 3.13.x Dec 24, 2023
@zaelgohary zaelgohary moved this from Pending review to In Verification in 3.13.x Dec 26, 2023
@A-Harby
Copy link
Contributor Author

A-Harby commented Dec 26, 2023

Waiting for #770

@zaelgohary
Copy link
Contributor

@A-Harby Should be working fine now after #1819 is merged.

@khaledyoussef24
Copy link
Contributor

khaledyoussef24 commented Jan 2, 2024

node count fixed to change to zero when there is no nodes:
environment used : devnet
image
checked for down, standby and up.
Screenshot from 2024-01-02 12-58-15
Screenshot from 2024-01-02 12-58-11

Screenshot from 2024-01-02 12-58-19

testlodge : https://app.testlodge.com/a/26076/projects/40893/suites/234374?expand_section=422340#case_4150459

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.13.x Jan 2, 2024
@ramezsaeed
Copy link
Contributor

Verified:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard type_bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants