Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Node Finder experience #2129

Closed
zaelgohary opened this issue Feb 6, 2024 · 6 comments
Closed

Enhance Node Finder experience #2129

zaelgohary opened this issue Feb 6, 2024 · 6 comments
Assignees
Labels
enhancements Small changes that can enhance the code/UI
Milestone

Comments

@zaelgohary
Copy link
Contributor

zaelgohary commented Feb 6, 2024

Filters take almost 100vh from the viewport and user needs to scroll to see the table.

image

Suggested solution: Let's use compact filter input instead. Also, not all filters should be shown to the user. Some should be shown as default and the others can be added if the user needs (from a dropdown menu or sth).

Reduce columns in nodes table. Users can access additional details by clicking on individual table rows anyway.

image

Display node type hints above the table instead of below it. With a pagination setting of 50 items per page, placing this information below the table would require excessive scrolling for the user.

image

Related Issues:

@zaelgohary zaelgohary added the enhancements Small changes that can enhance the code/UI label Feb 6, 2024
@ramezsaeed ramezsaeed added this to the 2.4.0 milestone Feb 12, 2024
@ramezsaeed
Copy link
Contributor

Related to:
#2132

@MohamedElmdary MohamedElmdary moved this to Accepted in 3.14.x Feb 14, 2024
@ehab-hassan ehab-hassan moved this from Accepted to In Progress in 3.14.x Mar 24, 2024
@ehab-hassan
Copy link
Contributor

work in progress(WIP)

the horizontal filter was designed to take 15% of the screen and by default closed, but while we have many items to filter we need to back to put it on the left side @MohamedElmdary suggest to give the user the option to hide the sidebar at pages contain filter( Node Finder,dedicated-nodes,farm-finder) so we can have more space for filter

image
image

Note: that'll cause scroll at the table on small screen

@MohamedElmdary MohamedElmdary self-assigned this Mar 31, 2024
@MohamedElmdary MohamedElmdary moved this from In Progress to Pending Review in 3.14.x Mar 31, 2024
@MohamedElmdary MohamedElmdary moved this from Pending Review to In Verification in 3.14.x Apr 3, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Apr 3, 2024

  1. Can you change the place of the Select Node Status filter? It's the most used filter on the page, and for better UX, it should be easily accessible instead of being at the bottom of the page.
  2. Having the apply button at the top of the filter doesn't seem like the best position for it; it doesn't feel good to keep scrolling up and down to choose filters and apply them.
  3. Maybe you can also group similar inputs together instead of having the type input and list input in shuffles, and then toggles in last (and order them in the most used first).
screen-capture.23.webm

@A-Harby A-Harby moved this from In Verification to Accepted in 3.14.x Apr 3, 2024
@ehab-hassan ehab-hassan moved this from Accepted to In Progress in 3.14.x Apr 4, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Apr 4, 2024

After discussing it with @ehab-hassan we agreed that it would be better for the apply button to be at the top and reorder the filter with most useful first (so the user scrolling would be minimal).

The order is:

  1. The Toggles
    A. Dedicated
    B. Gateway
    C. GPU
  2. Node status filter
  3. Node ID
  4. Farm ID
  5. 3 other lists (farm names - regions - countries)
  6. Free public IPs
  7. Free resources
  8. Min resources

@ehab-hassan ehab-hassan mentioned this issue Apr 4, 2024
5 tasks
@ehab-hassan ehab-hassan moved this from In Progress to In Verification in 3.14.x Apr 4, 2024
@ehab-hassan
Copy link
Contributor

Work Completed
Untitled-1

@khaledyoussef24
Copy link
Contributor

verified on devnet
version : bef3f8f
the new order of the node finder :

Image
Image
Image

  1. The Toggles
  2. Node status filter
  3. Node ID
  4. Farm ID
  5. 3 other lists (farm names - regions - countries)
  6. Free public IPs
  7. Free resources
  8. Min resources

nodes are now in cards which is better for small screens and no need for horizontal scrolling.

Image

toggles now only take action after clicking on apply

Screen.Recording.2024-04-07.at.9.06.41.AM.mov

node cards
filtering toggle
filters

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.14.x Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Small changes that can enhance the code/UI
Projects
Status: Done
Development

No branches or pull requests

6 participants