Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 (Qanet)[Bug]: the error color of grace period dedicated node is weird #2572

Closed
1 task done
khaledyoussef24 opened this issue Apr 16, 2024 · 6 comments
Closed
1 task done
Assignees
Labels
dashboard type_bug Something isn't working
Milestone

Comments

@khaledyoussef24
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

rented a dedicated node and let it go to grace period and then tried to deploy the error message were clear but the color was weird.

#1390

Steps To Reproduce

No response

which network/s did you face the problem on?

Dev

version

a03d4ed

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

image

Relevant log output

na
@khaledyoussef24 khaledyoussef24 added type_bug Something isn't working dashboard labels Apr 16, 2024
@ramezsaeed ramezsaeed added this to 3.14.x May 1, 2024
@ramezsaeed ramezsaeed added this to the 2.5.0 milestone May 1, 2024
@Mahmoud-Emad Mahmoud-Emad moved this to Accepted in 3.14.x May 1, 2024
@samaradel samaradel self-assigned this May 7, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.14.x May 7, 2024
@samaradel
Copy link
Contributor

samaradel commented May 7, 2024

image
validation on the input now I can't reproduce the issue @khaledyoussef24 please verify

@samaradel samaradel moved this from In Progress to Blocked in 3.14.x May 7, 2024
@AhmedHanafy725 AhmedHanafy725 moved this from Blocked to In Verification in 3.14.x May 13, 2024
@khaledyoussef24
Copy link
Contributor Author

The error is still producible.
steps to produce:

  1. rent a node.
  2. transfer all the tfts to another account.
  3. wait for the billing cycle.
  4. try to deploy on dedicated node.

, is the color of the error acceptable or should it be red?

Image

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Accepted in 3.14.x May 19, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.14.x May 19, 2024
@samaradel
Copy link
Contributor

Work Completed:

Fix nodes contract in grace period toast

@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x May 19, 2024
@samaradel samaradel moved this from Pending Review to In Verification in 3.14.x May 20, 2024
@khaledyoussef24 khaledyoussef24 changed the title 🐞 [Bug]: the error color of grace period dedicated node is weird 🐞 [Bug]: the error color of grace period dedicated node is weird [Qanet] Jun 6, 2024
@khaledyoussef24 khaledyoussef24 changed the title 🐞 [Bug]: the error color of grace period dedicated node is weird [Qanet] 🐞 (Qanet)[Bug]: the error color of grace period dedicated node is weird Jun 6, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Jun 12, 2024

The toast is fixed in the manual selection, But the deploy button is enabled and when I deploy, it gives me an error, which the wrong error message also.

The load node should give me an error on both automatic and manual selection because the rented node is on a grace period.

screen-capture.34.webm

@A-Harby A-Harby moved this from In Verification to Accepted in 3.14.x Jun 12, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.14.x Jun 13, 2024
@samaradel
Copy link
Contributor

It's a different issue now. please create an issue for the behavior

@A-Harby
Copy link
Contributor

A-Harby commented Jun 25, 2024

Verified, QA 2.5.0-rc3.

The color and alert are now clear.
image

I created another issue for deploying #3025.

@A-Harby A-Harby moved this from In Verification to Done in 3.14.x Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants