Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 (Qanet)[Bug]: node contracts on rent contracts alert doesn't appear on contract lock details #2687

Closed
1 task done
0oM4R opened this issue May 13, 2024 · 3 comments
Closed
1 task done
Assignees
Labels
dashboard type_bug Something isn't working
Milestone

Comments

@0oM4R
Copy link
Contributor

0oM4R commented May 13, 2024

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

I have rent contract on grace period, and when open the node contracts i found the locked amount 0 tfts, that is because the node contracts is on rented contract. we should handled this case before.

<v-alert
v-if="contractLocked?.amountLocked == 0 && isNodeInRentContracts"
class="ma-4"
type="warning"
variant="tonal"
>
This contract is in a grace period because it's on a dedicated machine also in a grace period. That's why this
node is locked with zero TFTS and no billing rate.
</v-alert>

Steps To Reproduce

  1. rent node
  2. deploy vm on the rented node
  3. wait for the rent contract to be in grace period
  4. in node contracts table click on grace period chip on the deployed vm
  5. you will see 0 tft as locked amount without any alerts

which network/s did you face the problem on?

Dev

version

2.4.0

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

Screenshot from 2024-05-13 11-17-11

Relevant log output

.
@0oM4R 0oM4R added the type_bug Something isn't working label May 13, 2024
@0oM4R 0oM4R self-assigned this May 13, 2024
@AhmedHanafy725 AhmedHanafy725 added this to the 2.5.0 milestone May 13, 2024
@AhmedHanafy725 AhmedHanafy725 moved this to Accepted in 3.14.x May 13, 2024
@0oM4R 0oM4R moved this from Accepted to Pending Review in 3.14.x May 14, 2024
@zaelgohary zaelgohary moved this from Pending Review to In Verification in 3.14.x May 22, 2024
@khaledyoussef24 khaledyoussef24 changed the title 🐞 [Bug]: node contracts on rent contracts alert doesn't appear on contract lock details 🐞 (Qanet)[Bug]: node contracts on rent contracts alert doesn't appear on contract lock details Jun 9, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Jun 12, 2024

It's still showing the same thing: 0 tft with no alert.
And with new unlock button, it shows the unlock button as enabled and clickable (the click doesn't do anything, apparently but it's very confusing.)

screen-capture.33.webm

@A-Harby A-Harby moved this from In Verification to Accepted in 3.14.x Jun 12, 2024
@0oM4R 0oM4R moved this from Accepted to In Progress in 3.14.x Jun 13, 2024
@0oM4R 0oM4R moved this from In Progress to Pending Review in 3.14.x Jun 13, 2024
@0oM4R
Copy link
Contributor Author

0oM4R commented Jun 13, 2024

I noticed that the unlock all contracts and unlock buttons are not shown in the table, even if i select only grace period contracts,
this should be fixed in commit
image

@0oM4R 0oM4R moved this from Pending Review to In Verification in 3.14.x Jun 13, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Jun 25, 2024

Verified, QA 2.5.0-rc3.

The contract deployed on the grace period rented node doesn't show the unlock button anymore.
image
And unlock all contract is now displayed.
image

TC2719 - Unlock Grace period Contract

TC2729 - Unlock All Grace period Contract

@A-Harby A-Harby moved this from In Verification to Done in 3.14.x Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants