Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 [Bug]: Domains icon doesn't appear on light mode #3488

Closed
1 task done
0oM4R opened this issue Oct 1, 2024 · 5 comments
Closed
1 task done

🐞 [Bug]: Domains icon doesn't appear on light mode #3488

0oM4R opened this issue Oct 1, 2024 · 5 comments
Assignees
@ehab-hassan
Labels
type_bug Something isn't working
Milestone
2.6.0

Comments

@0oM4R
Copy link
Contributor

0oM4R commented Oct 1, 2024

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

image

Steps To Reproduce

No response

which network/s did you face the problem on?

Dev

version

205fd89

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

.

Relevant log output

.
@0oM4R 0oM4R added the type_bug Something isn't working label Oct 1, 2024
@ramezsaeed ramezsaeed added this to 3.15.x Oct 2, 2024
@ramezsaeed ramezsaeed added this to the 2.6.0 milestone Oct 2, 2024
@maayarosama maayarosama moved this to Accepted in 3.15.x Oct 2, 2024
@xmonader
Copy link
Contributor

xmonader commented Oct 8, 2024

@ehab-hassan is it feasible to fix it in 3.15?

@ehab-hassan
Copy link
Contributor

Checking...

@ehab-hassan
Copy link
Contributor

ehab-hassan commented Oct 8, 2024 •
edited
Loading

image

I suggest using a material design icon rather than the image to match with other icons at hover & click

@ehab-hassan ehab-hassan self-assigned this Oct 8, 2024
@ehab-hassan ehab-hassan moved this from Accepted to In Progress in 3.15.x Oct 8, 2024
@ehab-hassan ehab-hassan mentioned this issue Oct 8, 2024
Merged
5 tasks
@ehab-hassan ehab-hassan moved this from In Progress to Pending Review in 3.15.x Oct 8, 2024
@ehab-hassan
Copy link
Contributor

fixed

@xmonader xmonader moved this from Pending Review to In Verification in 3.15.x Oct 8, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Oct 15, 2024

Verified, Devnet 038404b.

The domain icon is now appearing in both light and dark mode.
image

@A-Harby A-Harby moved this from In Verification to Done in 3.15.x Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehab-hassan ehab-hassan

Labels
type_bug Something isn't working
Projects
3.15.x
Status: Done
Milestone
2.6.0
Development

No branches or pull requests
5 participants
@xmonader @ehab-hassan @ramezsaeed @0oM4R @A-Harby