Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[provision][disk] Make sure to order disks in deployments to bigger ones are allocated first #2016

Closed
muhamadazmy opened this issue Jul 31, 2023 · 1 comment
Closed

[provision][disk] Make sure to order disks in deployments to bigger ones are allocated first #2016

muhamadazmy opened this issue Jul 31, 2023 · 1 comment
Assignees
@AbdelrahmanElawady
Labels
type_feature New feature or request
Milestone
3.8

Comments

@muhamadazmy
Copy link
Member

Related to threefoldtech/tfgrid-sdk-ts#886
@muhamadazmy
Copy link
Member Author

For DEV

https://github.com/threefoldtech/zos/blob/main/pkg/provision/engine.go#L872

this is where we sort workloads by types, before deploying, a second sort on workloads of disk type, a sort must be done so bigger disks comes first. (descending order on disks size)

@AbdelrahmanElawady AbdelrahmanElawady mentioned this issue Jul 31, 2023
Merged
@xmonader xmonader added the type_feature New feature or request label Aug 8, 2023
@xmonader xmonader added this to 3.11.x Aug 8, 2023
@xmonader xmonader moved this to Done in 3.11.x Aug 8, 2023
@xmonader xmonader added this to the 3.8 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbdelrahmanElawady AbdelrahmanElawady

Labels
type_feature New feature or request
Projects
No open projects
3.11.x
Status: Done
Milestone
3.8
Development

No branches or pull requests
3 participants
@xmonader @muhamadazmy @AbdelrahmanElawady