Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get the result of the public ip validation #2114

Closed
Tracked by #2122 ...
AhmedHanafy725 opened this issue Nov 15, 2023 · 4 comments
Closed
Tracked by #2122 ...

Can't get the result of the public ip validation #2114

AhmedHanafy725 opened this issue Nov 15, 2023 · 4 comments
Assignees
Labels
type_bug Something isn't working
Milestone

Comments

@AhmedHanafy725
Copy link
Collaborator

Env: devnet
nodeId: 12

Steps

  • Get public ip validation test result through RMB call zos.perf.get_all.

Result

no result was found on node 12 (the node with the smallest ID and up state) as node 11 is down (the last updateAt for node 11 Tuesday, November 14, 2023 12:54:12 PM GMT)

{ name: 'PublicIPValidation', timestamp: 1700028002, result: null },

Expectations

as node 11 has been down since yesterday, I was expecting to see the public ip validation result on node 12.

@ramezsaeed ramezsaeed added the type_bug Something isn't working label Nov 15, 2023
@ramezsaeed ramezsaeed added this to the 3.13 milestone Nov 15, 2023
@muhamadazmy
Copy link
Member

image

Seems that node 12 still thinks that there is another node that should do the tests. Maybe it doesn't take into account if the node is not up anymore.

@AbdelrahmanElawady can you please take a look why that is

@muhamadazmy
Copy link
Member

@Omarabdul3ziz please update this issue.

@Omarabdul3ziz Omarabdul3ziz moved this from In Progress to Pending review in 3.13.x Nov 20, 2023
@Omarabdul3ziz
Copy link
Contributor

updated the node status decision part, to use graphql client instead of directly calling the chain.

@Omarabdul3ziz Omarabdul3ziz moved this from Pending review to In Verification in 3.13.x Nov 21, 2023
@khaledyoussef24
Copy link

issue is not producible any more

 "description": "Runs on the least NodeID node in a farm to validate all its IPs.",
    "name": "public-ip-validation",
    "result": {
      "185.206.122.16/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.17/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.18/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.19/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.20/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.21/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.22/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.23/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.24/24": {
        "reason": "",
        "state": "valid"
      },
      "185.206.122.25/24": {
        "reason": "",
        "state": "valid"
      },
      "185.206.122.26/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.27/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.28/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.29/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.30/24": {
        "reason": "",
        "state": "valid"
      },
      "185.206.122.33/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.34/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.35/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.36/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.37/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.38/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.39/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.40/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.41/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.42/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.43/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.44/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.45/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.46/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.47/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.48/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.49/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.50/24": {
        "reason": "ip is already assigned to a contract",
        "state": "skipped"
      },
      "185.206.122.51/24": {
        "reason": "",
        "state": "valid"
      },
      "185.206.122.52/24": {
        "reason": "",
        "state": "valid"
      }

tried this and compared some random nodes with graphql queries and validated that they have the same results
image
image

@github-project-automation github-project-automation bot moved this from In Verification to Done in 3.13.x Nov 28, 2023
@muhamadazmy muhamadazmy modified the milestones: 3.13, 3.10.x Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants