-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans for Java 9 Jigsaw (modules) support? #117
Comments
We can certainly provide a module descriptor file for the main Getdown jar file. But Getdown bundles its dependencies internally (and uses Proguard to rename and minify them), so it wouldn't really provide any particular benefits. The Getdown code is mainly used as a standalone Java app that updates and launches another app, but in some cases it is useful to have Getdown itself as a dependency of the app being launched, so having it be a module for that use case could be useful. |
I tried to inject a module descriptor into Getdown, but when building the custom JRE, jlink required all dependent jars also to be modules and not automatic modules. |
I just took a stab at properly modularizing Getdown but there are a bunch of challenges. I have overcome most of them but Proguard is causing trouble. It has a bug handling |
Check out my project update4j for a fully modular updater. |
ProGuard appears to be up to version 7.2.2. Has a newer version been adopted? Will the modules work now? (Not that I am in need, just wondered if this issue can be closed relatively easily.) |
I am trying to build an installer approach of using Getdown through Jlink that would include a runtime.
Are there any plans to modularize Getdown and possibly it's dependencies including Samskivert.jar.
The text was updated successfully, but these errors were encountered: