Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans for Java 9 Jigsaw (modules) support? #117

Open
NasserAlzughaibi93 opened this issue Aug 22, 2018 · 5 comments
Open

Plans for Java 9 Jigsaw (modules) support? #117

NasserAlzughaibi93 opened this issue Aug 22, 2018 · 5 comments

Comments

@NasserAlzughaibi93
Copy link

I am trying to build an installer approach of using Getdown through Jlink that would include a runtime.

Are there any plans to modularize Getdown and possibly it's dependencies including Samskivert.jar.

@samskivert
Copy link
Member

We can certainly provide a module descriptor file for the main Getdown jar file. But Getdown bundles its dependencies internally (and uses Proguard to rename and minify them), so it wouldn't really provide any particular benefits.

The Getdown code is mainly used as a standalone Java app that updates and launches another app, but in some cases it is useful to have Getdown itself as a dependency of the app being launched, so having it be a module for that use case could be useful.

@NasserAlzughaibi93
Copy link
Author

I tried to inject a module descriptor into Getdown, but when building the custom JRE, jlink required all dependent jars also to be modules and not automatic modules.

@samskivert
Copy link
Member

I just took a stab at properly modularizing Getdown but there are a bunch of challenges.

I have overcome most of them but Proguard is causing trouble. It has a bug handling module-info class files which is fixed but not released, so I want to wait for Proguard 6.1 to come out before I fool around with this more.

@mordechaim
Copy link

Check out my project update4j for a fully modular updater.

@maeichris
Copy link
Contributor

ProGuard appears to be up to version 7.2.2. Has a newer version been adopted? Will the modules work now? (Not that I am in need, just wondered if this issue can be closed relatively easily.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants