Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'pipe' #283

Closed
2 tasks done
karolyi opened this issue May 20, 2020 · 1 comment · Fixed by #289
Closed
2 tasks done

Implement 'pipe' #283

karolyi opened this issue May 20, 2020 · 1 comment · Fixed by #289
Assignees
Labels
Add-On Issue affects the legacy thunderbird addon App Issue affects the standalone application enhancement
Milestone

Comments

@karolyi
Copy link

karolyi commented May 20, 2020

Prerequisites

  • Tried the most recent nightly build
  • Checked if your issue is already reported.

Is your feature request related to a problem?

Yes, pipe is not supported and so the editor UI doesn't load. For it to work in dovecot, you'll need the vnd.dovecot.pipe plugin required.

Describe the solution you'd like

pipe is a valid command in sieve for redirecting the email into a script. I have it in my own manually edited sieve file, which when trying to load with the plugin, gives an error.

Additional context

Just an additional info, the UI should be adjusted for handling preset colors. I have my thunderbird colors overridden from the settings, which makes it look like this:
image
As it can be seen, the checkboxes (toggles) are unable to see which state they're in. Also, the editor looks like this (also notice the require line for the pipe plugin):
image
I can live with that, but for example, selected text is not displayed as selected.
Excerpt of the visual editor:
image

@thsmi thsmi added Add-On Issue affects the legacy thunderbird addon App Issue affects the standalone application enhancement labels May 22, 2020
@thsmi
Copy link
Owner

thsmi commented May 22, 2020

Concerning the pipe extension:

The prefix (vnd) indicates, it is a vendor specific, non even standardized in an rfc. It is dovecot specific. Implementing support for the extension is not difficult but needs some time and is definitely a low priority task. So don't expect this to land soon. If you want to speed it up feel free to contribute a patch.

Concerning the Dark mode:

The UI uses Bootstrap (https://getbootstrap.com/) from Twitter as Framework. Which does not provide an official dark theme and thus has no support for a dark mode.

Bootstrap uses complex styling rules and fine tuned styles, so it would be a miracle if just changing the HTML Default colors would do the job. So there is not much which could be done here.

@thsmi thsmi added this to the Future milestone May 22, 2020
@thsmi thsmi linked a pull request May 24, 2020 that will close this issue
@thsmi thsmi modified the milestones: Future, 0.6 Jun 1, 2020
@thsmi thsmi self-assigned this Jun 1, 2020
@thsmi thsmi modified the milestones: 0.6, 0.5 Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add-On Issue affects the legacy thunderbird addon App Issue affects the standalone application enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants