Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The best practice using Tianshou for offline RL? #188

Closed
2 of 8 tasks
szrlee opened this issue Aug 20, 2020 · 1 comment · Fixed by #263
Closed
2 of 8 tasks

The best practice using Tianshou for offline RL? #188

szrlee opened this issue Aug 20, 2020 · 1 comment · Fixed by #263
Labels
discussion Discussion of a typical issue

Comments

@szrlee
Copy link

szrlee commented Aug 20, 2020

  • I have marked all applicable categories:
    • exception-raising bug
    • RL algorithm bug
    • documentation request (i.e. "X is missing from the documentation.")
    • new feature request
  • I have visited the source website
  • I have searched through the issue tracker for duplicates
  • I have mentioned version numbers, operating system and environment, where applicable:
    import tianshou, torch, sys
    print(tianshou.__version__, torch.__version__, sys.version, sys.platform)

What might be a best practice using Tianshou for offline RL?
Save to the buffer and pickle it to storage and then use it as an offline replay buffer (no further data gathering) for algorithm training?

offline-RL

This issue has some relevant discussion but I am not talking about TPU. #24 (comment)

@szrlee szrlee changed the title What might be a best practice using Tianshou for offline RL? The best practice using Tianshou for offline RL? Aug 20, 2020
@Trinkle23897
Copy link
Collaborator

What might be a best practice using Tianshou for offline RL?
Save to the buffer and pickle it to storage and then use it as an offline replay buffer (no further data gathering) for algorithm training?

I think so. The buffer save/load has been supported in #182. Other parts of the code are similar to imitation learning.

@Trinkle23897 Trinkle23897 added the discussion Discussion of a typical issue label Aug 24, 2020
@Trinkle23897 Trinkle23897 linked a pull request Dec 16, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion of a typical issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants