Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping daemon via wrapper script can kill unrelated processes #30

Open
hrenfroe opened this issue Apr 8, 2015 · 0 comments
Open

Stopping daemon via wrapper script can kill unrelated processes #30

hrenfroe opened this issue Apr 8, 2015 · 0 comments
Assignees
Labels
Milestone

Comments

@hrenfroe
Copy link

hrenfroe commented Apr 8, 2015

In v1.2.2 and earlier (at least to 1.1.9), calling 'ruby mydaemon_control.rb stop' can kill one of the invoking user's other processes if the pidfile contains the pid of one of those processes. I was surprised by this when, after trying to stop a daemon that wasn't running, my IDE spontaneously closed.

The issue seems to be that the process is just sent a stop signal without checking to see if it's actually the daemon process we want to stop. (Pidfile cleanup works normally for me, but I don't bother to stop any running daemons before I shut down my dev box, so I tend to get stale pidfiles.) I've solved similar issues in the past by checking the process name (if the process is running) before taking any action on it.

@thuehlinger thuehlinger self-assigned this Jun 25, 2015
@thuehlinger thuehlinger added this to the 1.3.0 milestone Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants