Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexsearch 0.7.41 breaks search on new deployment #84

Closed
jollydodo opened this issue Jan 9, 2024 · 3 comments
Closed

Flexsearch 0.7.41 breaks search on new deployment #84

jollydodo opened this issue Jan 9, 2024 · 3 comments

Comments

@jollydodo
Copy link
Contributor

Description

Noticed that the flex search functionality wasn't working after an automatic scheduled Netlify deploy. Confirmed that this was also the case with a new clean doks-install.

Steps to reproduce

  1. clone Doks and run npm install
  2. The problem shows with npm run dev and in the build versions
  3. However, my local version still does some caching so the problem doesn't show here. Only on deployment or a new clone

Expected result

Search bar should load on click. (will add the console error tomorrow. Currently fixed the problem in my deployment by going back to 0.7.31

Actual result

no search bar shows up.

Additional

I have some dynamic content on a new website (very simple stuff that checks for a date and removes events if the date has passed). Therefore the website redeploys every week on Netlify. However, I'm struggling with all these dependencies. I ran my personal Hugo portfolio for years on Hugo now, but that is a very simple website that gets updated very infrequently. I'm now really debating if a complex Hugo website with all these dependencies is able to keep this new website low maintenance ( I don't want to fix problems after each weekly redeploy since it's a website for an organisation where the people maintaining it don't necessarily are coders). Any tips for this? I'm open for suggestions :)

@h-enk
Copy link
Member

h-enk commented Jan 11, 2024

Not sure if related, but FlexSearch (also) broke for me with the latest version 0.7.31

I fixed my issue with https://github.com/gethyas/doks-core/pull/86/files#diff-817f7ddc38268fe8ecb65706db50973c273680c26f790b8a25ccf72d2c89c38f

I haven't tested this fix with v0.7.43 yet though

@h-enk
Copy link
Member

h-enk commented Jan 15, 2024

Tested with 0.7.43 and the import fix works — for me

@h-enk
Copy link
Member

h-enk commented Mar 1, 2024

Merged: #86

@h-enk h-enk closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants