Fix weekday selection and quick link to get disabled #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmount
commented
Sep 26, 2024
| @@ -167,6 +167,7 @@ const onChange = () => { | |||
| overflow: hidden; | |||
| max-width: 40%; | |||
| text-wrap: nowrap; | |||
| z-index: 1; | |||
There was a problem hiding this comment.
For some weird reason the prefix element gets hidden behind the input as soon as that gets disabled 🤷🏻
Comment on lines
-875
to
-878
| .bubble-select { | ||
| gap: .25rem; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is handled by the BubbleSelect component itself now and hence not needed anymore.
MelissaAutumn
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Context
I also added the changes to a corresponding PR in services-ui:
thunderbird/services-ui#4
Applicable Issues
Closes #686