Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No popup and Confirmation while Deleting, Spam any Email #2384

Closed
meghalagrawal opened this issue Mar 12, 2017 · 5 comments
Closed

No popup and Confirmation while Deleting, Spam any Email #2384

meghalagrawal opened this issue Mar 12, 2017 · 5 comments

Comments

@meghalagrawal
Copy link

meghalagrawal commented Mar 12, 2017

Expected behavior

When deleting an Email either from list or from inside an Email there should be a popup saying are you sure you want to Delete the Email ??
Asking Delete or Cancle to User will reduce chances of Accidental Deletion of Email.

Actual behavior

When we are deleting an Email its not asking for Confirmation and its deleting it directly.

Steps to reproduce

1.Need to check why ConfirmationDialogFragment is not being shown while deleting.
2. Fix the issue that is causing it as its not even shown while moving to Spam.

Environment

K-9 Mail version:
5.203

Android version:
6.0.1
Account type (IMAP, POP3, WebDAV/Exchange):
All

@meghalagrawal
Copy link
Author

meghalagrawal commented Mar 12, 2017

Can you please assign it to me?

I will do this within 2 days.

@meghalagrawal meghalagrawal changed the title No popup and Confirmation while Deleting any Email No popup and Confirmation while Deleting, Spam any Email Mar 12, 2017
@cketti
Copy link
Member

cketti commented Mar 12, 2017

This can already be enabled via a setting. See https://k9mail.github.io/documentation/settings/global.html#interactionconfirm-actions

@cketti cketti closed this as completed Mar 12, 2017
@meghalagrawal
Copy link
Author

meghalagrawal commented Mar 12, 2017

By default this setting should be turned on then ??

@cketti
Copy link
Member

cketti commented Mar 12, 2017

I disagree. Confirmation dialogs are quite disruptive. A better solution is to support Undo. And we have an issue for that: #624

@meghalagrawal
Copy link
Author

Okay Thanks.

Can I work on Issue #624 ?? Can you assign the task to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants