Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title wraps within word in "Improve the Experience" screen #8257

Open
kewisch opened this issue Oct 7, 2024 · 4 comments
Open

Title wraps within word in "Improve the Experience" screen #8257

kewisch opened this issue Oct 7, 2024 · 4 comments
Labels
good first issue Ideal for newcomers to start contributing type: bug Something is causing incorrect behavior or errors

Comments

@kewisch
Copy link
Member

kewisch commented Oct 7, 2024

image
On more narrow phones like the Fold, the title wraps. I think we should (to an extent) allow the title to shrink so that Thunderbird fits in one line. I'm not sure there is an easy way without forcing the whole text to fit into one line.

@kewisch kewisch added type: bug Something is causing incorrect behavior or errors good first issue Ideal for newcomers to start contributing labels Oct 7, 2024
@kewisch kewisch added this to the Thunderbird for Android 8.0 milestone Oct 7, 2024
@sens-sens
Copy link

Hi, I'm new to contributing and currently learning Android development.
I believe I can help address this issue. I would like to suggest implementing a solution where the title can shrink proportionally on narrower devices like the Fold, to fit within a single line without affecting the rest of the UI. Would it be okay for me to work on this issue?

@ryanleesipes
Copy link

ryanleesipes commented Oct 9, 2024

@sens-sens please work on it, pull requests welcome!

The TB Android dev room on Matrix is: https://matrix.to/#/#tb-android-dev:mozilla.org

@sens-sens
Copy link

The code for the top app bar has inconsistent padding values.

Row(
    modifier = Modifier
        .fillMaxWidth()
        .padding(
            start = MainTheme.spacings.half,
            end = MainTheme.spacings.quadruple,
        )
        .then(modifier),
    horizontalArrangement = Arrangement.Center,
    verticalAlignment = Alignment.CenterVertically,
)

Since the row items are arranged to the center, we can reduce the end padding from MainTheme.spacings.quadruple (32 dp) to MainTheme.spacings.half (4 dp).

This change will provide consistent padding across the app bar while ensuring there’s enough space for the word "Thunderbird."

I've searched for other ways to reduce the size, but as far as I know, those options would modify the theme contents and font size, leading to increased complexity.

Most common foldable phones have a width of about 2.5 inches, so reducing the padding might help fix the issue. On larger screens, there will still be space after the word "Thunderbird" since the items are centered. I tested this in the preview functionality of Android Studio, as I don't have access to foldable emulators.

Can I proceed with this change and create a pull request?

@wmontwe
Copy link
Member

wmontwe commented Oct 9, 2024

We could move the title below the icon to give it enought room, the design was optimized for K-9 Mail which is way shorter. Playing with the paddings would collide with the other screens in the onboarding flow and might not work on very small screens.

@wmontwe wmontwe added status: needs design Issues requiring design decisions or inputs and removed status: needs design Issues requiring design decisions or inputs labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for newcomers to start contributing type: bug Something is causing incorrect behavior or errors
Projects
None yet
Development

No branches or pull requests

4 participants