Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog is not sorted by date #8577

Open
2 tasks done
myclevorname opened this issue Nov 18, 2024 · 4 comments
Open
2 tasks done

Changelog is not sorted by date #8577

myclevorname opened this issue Nov 18, 2024 · 4 comments
Assignees
Labels
type: bug Something is causing incorrect behavior or errors

Comments

@myclevorname
Copy link

Checklist

  • I have used the search function to see if someone else has already submitted the same bug report.
  • I will describe the problem with as much detail as possible.

App

Thunderbird for Android

App version

8.1

Where did you get the app from?

F-Droid

Android version

12

Device model

Samsung Galaxy S10e

Steps to reproduce

  1. Go to Settings
  2. Press About, then Version
  3. Scroll down

Expected behavior

Versions should be in order

Actual behavior

Version 8.2b2 and 8.2b3 are in the wrong order

Image

Bonus issue too small to be its own issue: The word "aka" in the Github repo description is misspelled as "fka"

Logs

No response

@myclevorname myclevorname added type: bug Something is causing incorrect behavior or errors unconfirmed Newly reported issues awaiting triage or confirmation labels Nov 18, 2024
@sirtao
Copy link
Contributor

sirtao commented Nov 18, 2024

Motorola Moto Edge 50 Ultra
Android 14

Same issue on K-9 8.1 from Play Store
Similar issue on Thunderbord 8.1 from F-Droid

screenshots to follow

K-9 (longer changelog for context)

Thunderbird

@cketti
Copy link
Member

cketti commented Nov 18, 2024

@kewisch @coreycb The changelog is sorted by version code. The easiest solution I can see is to not include the changelog entries from beta in release.

@cketti cketti removed the unconfirmed Newly reported issues awaiting triage or confirmation label Nov 18, 2024
@kewisch
Copy link
Member

kewisch commented Nov 18, 2024

Agree, I think the fact that betas were included was a result of merges and not a clear idea of what to do with the changelog. Maybe we should generate the full changelog xml file from the (various) yaml files in the android_beta or android_release subdirectories each time, or we need to adjust/create a merge day script that will clean up the files accordingly.

@kewisch kewisch self-assigned this Nov 18, 2024
@wmontwe
Copy link
Member

wmontwe commented Nov 19, 2024

We could use different files for the different build types. At the moment the file is located at app-thunderbird/src/main/res/raw but we could add it to:

  • Daily: app-thunderbird/src/daily/res/raw
  • Beta: app-thunderbird/src/beta/res/raw
  • Release: app-thunderbird/src/release/res/raw

So every variant will only include it's own changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something is causing incorrect behavior or errors
Projects
None yet
Development

No branches or pull requests

5 participants