-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large file not firing all shortcodes with Regular Parser #77
Comments
@rhukster I thought that the file being large was the least probable cause so I ruled it out first by reducing your document to contain only shortcodes without any text - nothing changed. I played a bit with the result until I found the issue: there is a shortcode "syntax error" on line 817 - notice the missing apostrophe in the parameter value: I kept reducing the document until I found the smallest example to reproduce the issue: I just published #78 with tests and a fix for this issue. Please verify your inputs using |
Hah, well thanks for finding my bug :) Just glad it also managed to shine a light on an issue with the Regular parser at the same time. I've tested with the I'll release a new version of the Grav |
Hi @rhukster, I just tagged By the way, I'm wondering, what do you think about the code below:
Currently |
I think it makes more sense for both of those shortcodes to be invalid. There's really no possible reason that a missing double quote should be considered OK. And having BTW, thanks for the 0.7.2 release.. my plugin is updated with it also. Cheer! |
Per #70, I'm still having this issue. Attached is a zip to help debug:
thuderer-shortcode-issue#77.zip
Just extract, run
composer install
and thenphp shortcode.php
The output with each parser can be seen via this online diff: https://www.diffchecker.com/vejLhuQq
Notice, the shortcodes are processed at the bottom of the file for the regular parser, but as things progress upwards, it cuts out.
The text was updated successfully, but these errors were encountered: