Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

作者c++工程水平急需提高 #48

Open
firedtoad opened this issue Aug 27, 2021 · 1 comment
Open

作者c++工程水平急需提高 #48

firedtoad opened this issue Aug 27, 2021 · 1 comment

Comments

@firedtoad
Copy link

打开警告选项 红字满天飞
默认执行还会coredump

@zhangbo
Copy link

zhangbo commented Nov 16, 2021

警告比较多的是关于类型转换这块。
for(int i = 0; i < static_cast(sentence.size()); i++) 最好用 for (auto& item : sentence) {

比较想吐槽咱代码格式,也format一下吧:)

另外,最大的问题是,咱这个项目不是线程安全的。有没有可能改成线程安全的呀?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants