Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar items are not displayed correctly in DataGrip #13

Open
svenbit opened this issue Apr 26, 2020 · 10 comments
Open

Toolbar items are not displayed correctly in DataGrip #13

svenbit opened this issue Apr 26, 2020 · 10 comments
Labels
bug Something isn't working Hacktoberfest open for contributors under Hacktoberfest help wanted Extra attention is needed

Comments

@svenbit
Copy link

svenbit commented Apr 26, 2020

What/Why

The table data editor, query console, and results table toolbar doesn't seems to be displayed correctly when using Gradianto themes in DataGrip.

Steps to reproduce

  1. Change appearance theme to Gradianto (Dark Fuchsia / Deep Ocean / Midnight Blue)
  2. Open table data editor/query console
  3. Hover on any of the item in the toolbar
  4. The toolbar items displayed in the toolbar will be disoriented as you hover through the items

Additonal Information

DataGrip: 2020.1.2 Build #DB-201.6668.164
Operating System: Windows 10 18363.778

I have also tried to reproduce the issue on another DataGrip instance installed in another PC, and I was able to reproduce the issue.

Table Data Editor:
2020-04-26_15h33_06

Query Console:
2020-04-26_15h34_19

Query Results Table:
2020-04-26_15h34_30

@thvardhan thvardhan added bug Something isn't working help wanted Extra attention is needed labels Apr 26, 2020
@thvardhan
Copy link
Owner

thvardhan commented Apr 26, 2020

Hi thanks for reporting this issue. I'll take a look at it as soon as I get access to a computer.

P.S. really appreciate the detailed report.

@thvardhan
Copy link
Owner

Hi, I've tested the above but I am unable to reproduce the issue. Can you try updating data grid to latest version and check? it seems more like a data grid issue than theme because I am only changing the color values they should not overlap. if not then please let me know I'll check once again and if its still not fixed, then we can open an issue ticket with JetBrains.
Screenshot 2020-05-01 at 4 30 24 PM

Screenshot 2020-05-01 at 4 29 12 PM

@svenbit
Copy link
Author

svenbit commented May 1, 2020

Thank you for taking the time to check the issue.

The DataGrip version that I used was already in the latest version when I submitted the report (2020.1.2 Build #DB-201.6668.164).

But after I saw the screenshot that you have attached, I realized that the toolbar background color is different compared to the toolbar color in my DataGrip instance (the toolbar background color in my DataGrip instance was light green as shown in the screenshot in my first post).

So I did further check, and it turns out that I have the Database Color Settings enabled, and I can confirm that the issue only happens if you enable the Color Settings for the database and the Enable database colors in toolbars is checked.

2020-05-02_00h11_33

2020-05-02_00h12_45

I'm not sure if it is something that can be fixed from the theme configuration or it was due to a bug in DataGrip. But when I changed the appearance to other themes, the toolbar is displayed properly with the database color settings enabled.

I tried the following themes and all of them has not issue with the database color settings:

  • Dark Purple (From Marketplace, by Jetbrains)
  • Dracula (3rd Party)
  • High Contrast (Built-in)
  • Hiberbee Dark (3rd Party)
  • Windows 10 Light (Built-in)

@thvardhan
Copy link
Owner

Hi I've checked for the same on a Mac as I don't have access to windows pc right now. I'll check it on windows as soon as I get access to it. using the same build on Mac seems to be fine. again as mentioned will check with windows as soon as possible.
image

@thvardhan
Copy link
Owner

Hi can you confirm if the bug is still there? I know it has been a while but I've just got a friends windows pc I am unable to reproduce the issue.

@svenbit
Copy link
Author

svenbit commented Sep 25, 2020

Yes, the bug is still there for me, but it only happens if the database Color Settings is enabled as mentioned before.
The issue does not happen if the database color settings is not enabled (No Color).

Gradianto version: 4.2
DataGrip version: 2020.2.2 Build DB-202.6948.53

@thvardhan
Copy link
Owner

ok thanks for the headsup I'll recheck and get back

@thvardhan thvardhan added the Hacktoberfest open for contributors under Hacktoberfest label Sep 25, 2020
@ernstmarco
Copy link

Having same bug in Intellij while using colors for datasources:

image

Nice theme btw. 👍

@thvardhan
Copy link
Owner

Hello, it's been a while, I did a test back then but wasn't able to find anything and hence added the hacktoberfest label hoping for support, will keep this issue open for anyone coming in future.

can anyone confirm if this still happens in new UI?

@AndreiGorevoi
Copy link

AndreiGorevoi commented Oct 27, 2023

Hello, it's been a while, I did a test back then but wasn't able to find anything and hence added the hacktoberfest label hoping for support, will keep this issue open for anyone coming in future.

can anyone confirm if this still happens in new UI?

Hello @thvardhan. I confirm that the issue it still exists for the NEW UI. There are my steps for reproducing that issue:

  1. Selecting any Gradianto theme;

  2. Open build in tool for databases in IDEA;
    image

  3. Create some DB connection and select some custom color for that(this is the key of reproducing the problem)
    image
    image

  4. Then when you work with some of these connection(open console, some table and hover over panel) with custom colour it's some weird behaviour with colours:
    image

P.S. If you use DB connection/source with default colour it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Hacktoberfest open for contributors under Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants