Skip to content

Commit f14fd3d

Browse files
committed
Bring in ScreenSpaceEventHandler type fixes
from CesiumGS#9275
1 parent 1901113 commit f14fd3d

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

Source/Core/ScreenSpaceEventHandler.js

+7-6
Original file line numberDiff line numberDiff line change
@@ -934,12 +934,13 @@ function ScreenSpaceEventHandler(element) {
934934
registerListeners(this);
935935
}
936936

937+
// TODO: document callback signature for each type of event
937938
/**
938939
* Set a function to be executed on an input event.
939940
*
940941
* @param {Function} action Function to be executed when the input event occurs.
941-
* @param {Number} type The ScreenSpaceEventType of input event.
942-
* @param {Number} [modifier] A KeyboardEventModifier key that is held when a <code>type</code>
942+
* @param {ScreenSpaceEventType} type The ScreenSpaceEventType of input event.
943+
* @param {KeyboardEventModifier} [modifier] A KeyboardEventModifier key that is held when a <code>type</code>
943944
* event occurs.
944945
*
945946
* @see ScreenSpaceEventHandler#getInputAction
@@ -966,8 +967,8 @@ ScreenSpaceEventHandler.prototype.setInputAction = function (
966967
/**
967968
* Returns the function to be executed on an input event.
968969
*
969-
* @param {Number} type The ScreenSpaceEventType of input event.
970-
* @param {Number} [modifier] A KeyboardEventModifier key that is held when a <code>type</code>
970+
* @param {ScreenSpaceEventType} type The ScreenSpaceEventType of input event.
971+
* @param {KeyboardEventModifier} [modifier] A KeyboardEventModifier key that is held when a <code>type</code>
971972
* event occurs.
972973
*
973974
* @returns {Function} The function to be executed on an input event.
@@ -989,8 +990,8 @@ ScreenSpaceEventHandler.prototype.getInputAction = function (type, modifier) {
989990
/**
990991
* Removes the function to be executed on an input event.
991992
*
992-
* @param {Number} type The ScreenSpaceEventType of input event.
993-
* @param {Number} [modifier] A KeyboardEventModifier key that is held when a <code>type</code>
993+
* @param {ScreenSpaceEventType} type The ScreenSpaceEventType of input event.
994+
* @param {KeyboardEventModifier} [modifier] A KeyboardEventModifier key that is held when a <code>type</code>
994995
* event occurs.
995996
*
996997
* @see ScreenSpaceEventHandler#getInputAction

gulpfile.cjs

-3
Original file line numberDiff line numberDiff line change
@@ -1612,9 +1612,6 @@ function createTypeScriptDefinitions() {
16121612
// Wrap the source to actually be inside of a declared cesium module
16131613
// and add any workaround and private utility types.
16141614
source = `declare module "cesium" {
1615-
1616-
import * as when from "when";
1617-
16181615
${source}
16191616
}
16201617

0 commit comments

Comments
 (0)