Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openapi document with dependencies override (#5451) #5452

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix openapi document with dependencies override (#5451) #5452

wants to merge 5 commits into from
+392 −3

Conversation

lmignon
Copy link

@lmignon lmignon commented Oct 2, 2022 •
edited
Loading

refs #5451

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

📝 Docs preview for commit aed607d at: https://6339f3a6e3f39c274895ddee--fastapi.netlify.app

@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from aed607d to acf37ee Compare October 2, 2022 20:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

📝 Docs preview for commit acf37ee at: https://6339f80a0dfefb27382a1ac6--fastapi.netlify.app

@lmignon lmignon marked this pull request as draft October 2, 2022 20:49
@codecov
Copy link

codecov bot commented Oct 3, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cf73051) to head (e31a2c3).
Report is 1336 commits behind head on master.

❗ Current head e31a2c3 differs from pull request most recent head 9ae3c2e. Consider uploading reports for the commit 9ae3c2e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #5452   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          540       542    +2     
  Lines        13969     14003   +34     
=========================================
+ Hits         13969     14003   +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

📝 Docs preview for commit e5396cd at: https://633b40fa63c4ac2ee3f06d9d--fastapi.netlify.app

@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from e5396cd to 4ad2bc3 Compare October 3, 2022 20:09
@lmignon lmignon marked this pull request as ready for review October 3, 2022 20:11
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

📝 Docs preview for commit 4ad2bc3 at: https://633b422f18b80c30ba4d1c06--fastapi.netlify.app

@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from 4ad2bc3 to ee235fb Compare October 3, 2022 20:17
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

📝 Docs preview for commit ee235fb at: https://633b441611b92d32862315ee--fastapi.netlify.app

@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from ee235fb to 39fb6b4 Compare October 3, 2022 20:24
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

📝 Docs preview for commit 39fb6b4 at: https://633b45949cb90d34d468a0a3--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

📝 Docs preview for commit 3f7a29c at: https://633c175b5c3f4076c7a5e89e--fastapi.netlify.app

@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from 3f7a29c to 7ba81c5 Compare October 4, 2022 11:25
@lmignon
Copy link
Author

lmignon commented Oct 4, 2022

This PR also includes a commit to pin the version of trio since the last version 0.22.0 breaks tests. A fix is proposed here #5456

@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from 7ba81c5 to e31a2c3 Compare October 4, 2022 11:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

📝 Docs preview for commit e31a2c3 at: https://633c19e333bbe9797f5dda49--fastapi.netlify.app

yezz123
yezz123 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lmignon
Copy link
Author

lmignon commented Nov 14, 2022

@tiangolo No news about this one? IMO this changes makes a lot of sense but the way I fixed the code is may be not appropriate since that's the first time I dig into it.

@github-actions
Copy link
Contributor

📝 Docs preview for commit db3212f at: https://639cda9b2c118d005f47f6ee--fastapi.netlify.app

@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from db3212f to b915ccf Compare March 10, 2023 10:09
@github-actions
Copy link
Contributor

📝 Docs preview for commit b915ccf at: https://640b02dc77012078081ced3e--fastapi.netlify.app

@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from b915ccf to 3b7895b Compare June 9, 2023 14:52
@lmignon
Copy link
Author

lmignon commented Jun 9, 2023

@tiangolo I rebased this branch on 0.96.0. I hope it will find a path to be included into a next release.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

📝 Docs preview for commit 3b7895b at: https://64833db8a9aabd1989f2d478--fastapi.netlify.app

@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from 3b7895b to cb8573b Compare June 22, 2023 08:38
@lmignon
Copy link
Author

lmignon commented Jun 22, 2023

rebased on 0.97

@tiangolo
Copy link
Member

📝 Docs preview for commit cb8573b at: https://64940968de6ac3007e21b274--fastapi.netlify.app

@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from 682a1a4 to 5a062f3 Compare June 26, 2023 12:58
@lmignon
Copy link
Author

lmignon commented Jun 26, 2023

rebased on 0.98

@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch 2 times, most recently from 38efd0c to 973a53e Compare September 18, 2023 15:24
@lmignon lmignon marked this pull request as draft September 19, 2023 07:33
@lmignon
Copy link
Author

lmignon commented Sep 19, 2023

I'll adapt the code to work on the 1.X version

@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from 9a1fadd to 344e322 Compare October 6, 2023 16:34
@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from 344e322 to 7f11e98 Compare November 20, 2023 18:54
@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from 61fdc10 to eb35b5f Compare February 13, 2024 17:31
@lmignon lmignon marked this pull request as ready for review February 14, 2024 07:32
@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from 6280f4f to 9ae3c2e Compare March 13, 2024 14:40
@lmignon
Copy link
Author

lmignon commented Mar 13, 2024

rebased on 0.110.0

@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from 9ae3c2e to dc1b214 Compare September 20, 2024 14:04
@lmignon lmignon force-pushed the master-fix-openapi-with-overrides branch from 75389c4 to 8413c75 Compare September 20, 2024 14:09
@lmignon
Copy link
Author

lmignon commented Sep 20, 2024

rebased on 0.115.0

@tiangolo Any chance to get this reviewed or better merged? It's very useful. Thank you.

@sebastienbeau
Copy link

@tiangolo We are interested too. Thanks @lmignon for your work

@marielejeune
Copy link

@tiangolo I'm also interested! Could you please have a look? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yezz123 yezz123 yezz123 approved these changes

@BilalAlpaslan BilalAlpaslan BilalAlpaslan approved these changes

Assignees
No one assigned
Labels
p4 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lmignon @tiangolo @sebastienbeau @marielejeune @BilalAlpaslan @yezz123 @alejsdev