Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard welcome message to show email if full name doe not exists #129

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

rlonka
Copy link
Contributor

@rlonka rlonka commented Mar 10, 2020

In Dashboard the greeting did not show email in case UserProfile exists without fullname.
The condition never came to the else statement

The email was is not shown in welcome greeting message if full name does not exists
valentierra added a commit to valentierra/full-stack-fastapi-postgresql that referenced this pull request Apr 9, 2020
@tiangolo tiangolo merged commit 697b4da into fastapi:master Apr 17, 2020
@tiangolo
Copy link
Member

Ah, good catch, thank you! 🕵️ 🔍 🚀 🍰

gusevyaroslove pushed a commit to gusevyaroslove/fastapi-template that referenced this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants