Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Change .nvmrc format #1148

Merged
merged 1 commit into from
Apr 3, 2024
Merged

🔧 Change .nvmrc format #1148

merged 1 commit into from
Apr 3, 2024

Conversation

patrick91
Copy link
Contributor

@patrick91 patrick91 commented Apr 3, 2024 •
edited
Loading

I've noticed that 18.x.x is not supported by nvmrc:

❯ nvm install
Found '/Users/patrick/github/patrick91/full-stack-fastapi-template/frontend/.nvmrc' with version <18.x.x>
Version '18.x.x' not found - try `nvm ls-remote` to browse available versions.

it also doesn't work with mise (a similar tool that I use), but using 18 works fine for both tools 😊

18 and 18.x.x both work for fnm 😊

@alejsdev alejsdev changed the title Change nvmrc format 🔧 Change .nvmrc format Apr 3, 2024
@alejsdev alejsdev merged commit 822dbc5 into fastapi:master Apr 3, 2024
3 checks passed
@alejsdev
Copy link
Member

alejsdev commented Apr 3, 2024

Thank you! 🚀 @patrick91

gusevyaroslove pushed a commit to gusevyaroslove/fastapi-template that referenced this pull request Aug 4, 2024
@patrick91
🔧 Change .nvmrc format (fastapi#1148)
c7c0ce6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrick91 @alejsdev