-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Use suspense for items page #1167
Conversation
0f3466c
to
c14ed77
Compare
Items Management | ||
</Heading> | ||
|
||
<ErrorBoundary fallback={<div>Something went wrong</div>}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alejsdev what do you think of this?
I needed to add a new library, because you can't create error boundaries with functional components, and I thought it was better to import a new library rather than creating our own version of the component :D
https://react.dev/reference/react/Component#catching-rendering-errors-with-an-error-boundary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like this approach 😄
8375ee9
to
1acb9f0
Compare
Update to only suspend the table, it looks much better 😊 CleanShot.2024-04-15.at.13.55.01.mp4The only issue is the heading widths changing, but maybe we can live with that? (or we do set a fixed size for them) 😊 |
Yes, it looks nice! I think we can set a fixed size for it 🤔 |
Awesome, thanks! Looks great 🚀 |
I've also added a very simple skeleton
CleanShot.2024-04-11.at.10.30.26.mp4