Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify env files, merge to one .env #151

Merged
merged 1 commit into from
Apr 19, 2020
Merged

Simplify env files, merge to one .env #151

merged 1 commit into from
Apr 19, 2020

Conversation

tiangolo
Copy link
Member

@tiangolo tiangolo commented Apr 19, 2020

♻️ Simplify env files, merge to one .env.

Having multiple files for env variables could help to identify which configs belong to which services, but the same can be done with comments.

A single .env file could help to have a general idea of all the configs in a single place.
It will also help to simplify the development of the project generator itself, as env var templates now live in a single file that can be generated more easily.

Having files separated could help if there were conflicts between env var names for different services, but that's not the case. The other reason would be to not expose env vars to some services if they were not trusted, but that's also not the case here, all the services in this stack are part of the app itself and "trusted", so they can get the env vars, they just won't use them.

@tiangolo tiangolo merged commit a7d3671 into master Apr 19, 2020
@tiangolo tiangolo deleted the simplify-env branch April 19, 2020 07:17
gusevyaroslove pushed a commit to gusevyaroslove/fastapi-template that referenced this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant