🐛 Fix Poetry installation in Dockerfile and upgrade Python version and packages to fix Docker build #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@little7Li, thanks for the PR, I wanted to do it myself. I'd change the title to something like "Upgrade poetry installer to v1.2" to reflect more accurately the changes. The previous installer for poetry 1.1 works fine, no need to fix it, just make an upgrade. |
|
Would be great if this were merged soon. |
|
Bump! The provided URL now breaks build with a 404. |
tiangolo
changed the title
|
Awesome, thank you @little7Li! 😄 🍰 I updated the Python version as well as it was not building the Docker image, and I updated a couple of other dependencies needed for it to build and run. 🤓 Thanks @hcristea for the comment! ☕ |
This was referenced Nov 14, 2023
Closed
Closed
gusevyaroslove
pushed a commit
to gusevyaroslove/fastapi-template
that referenced
this pull request
Aug 4, 2024
…d packages to fix Docker build (fastapi#480) Co-authored-by: lidong293 <lidong310@jd.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
alejsdev
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The poetry installation url has to be updated as the old one is no longer valid.
And replace a poetry install option
--no-devwith a recommended one--only main.