Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with the new --help argument #135

Merged
merged 3 commits into from
Aug 16, 2020

Conversation

victorphoenix3
Copy link
Contributor

Fixes #124

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          242       242           
  Lines         4504      4508    +4     
=========================================
+ Hits          4504      4508    +4     
Impacted Files Coverage Δ
docs_src/testing/app01/main.py 100.00% <0.00%> (ø)
docs_src/options/version/tutorial003.py 100.00% <0.00%> (ø)
docs_src/parameter_types/bool/tutorial002.py 100.00% <0.00%> (ø)
docs_src/parameter_types/path/tutorial001.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e3e46...ae9ae5e. Read the comment docs.

@victorphoenix3
Copy link
Contributor Author

@tiangolo @Kludex This is ready for review.
The PR was initially failing build, had to run format.sh hence the large size of the PR.

@@ -46,7 +46,7 @@ $ python main.py --help
Usage: main.py [OPTIONS] [NAMES]...

Arguments:
[NAMES]... [default: Harry, Hermione, Ron]
[NAMES]... Select 3 characters to play with [default: Harry, Hermione,Ron]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[NAMES]... Select 3 characters to play with [default: Harry, Hermione,Ron]
[NAMES]... Select 3 characters to play with [default: Harry, Hermione, Ron]

@tiangolo tiangolo merged commit 39a6552 into fastapi:master Aug 16, 2020
@tiangolo
Copy link
Member

Thanks @victorphoenix3 ! 🚀 🍰

And thanks @Kludex for the review! ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs with new Arguments help section
3 participants