-
-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add click 8.1.0 support #375
Conversation
Thanks! This looks like a correct fix. |
I came to after experiencing the aforementioned bug just this afternoon, only to find y'all already had a fix in the works. Thanks! |
Traceback (most recent call last): |
This is a high priority bug fix! all new installations of typer are basically broken |
In 8.1.0 click removed the deprecated `get_terminal_size` function in favor of letting downstream projects import it from shutil. pallets/click#2130 fastapi/typer#375
If there's any way Adafruit can help get this merged and a release made, please @ me! |
Confirmed working. Anyone using Poetry for their dependencies can use: [tool.poetry.dependencies]
typer = { git = "https://github.com/madkinsz/typer.git", rev = "b6efa2f" } |
@tiangolo any chance you could take a look at this? Thank you |
📝 Docs preview for commit b6efa2f at: https://6244897abaa0e80081318186--typertiangolo.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 252 252
Lines 5287 5287
=========================================
Hits 5287 5287
Continue to review full report at Codecov.
|
Requires a Closing in favor of #380 |
Thank you @tiangolo |
In 8.1.0 click removed the deprecated `get_terminal_size` function in favor of letting downstream projects import it from shutil. pallets/click#2130 fastapi/typer#375
In 8.1.0 click removed the deprecated `get_terminal_size` function in favor of letting downstream projects import it from shutil. pallets/click#2130 fastapi/typer#375
In 8.1.0 click removed the deprecated `get_terminal_size` function in favor of letting downstream projects import it from shutil. pallets/click#2130 fastapi/typer#375
In 8.1.0 click removed the deprecated `get_terminal_size` function in favor of letting downstream projects import it from shutil. pallets/click#2130 fastapi/typer#375
In 8.1.0 click removed the deprecated `get_terminal_size` function in favor of letting downstream projects import it from shutil. pallets/click#2130 fastapi/typer#375
In 8.1.0 click removed the deprecated `get_terminal_size` function in favor of letting downstream projects import it from shutil. pallets/click#2130 fastapi/typer#375
In 8.1.0 click removed the deprecated `get_terminal_size` function in favor of letting downstream projects import it from shutil. pallets/click#2130 fastapi/typer#375
In 8.1.0 click removed the deprecated `get_terminal_size` function in favor of letting downstream projects import it from shutil. pallets/click#2130 fastapi/typer#375
In 8.1.0 click removed the deprecated `get_terminal_size` function in favor of letting downstream projects import it from shutil. pallets/click#2130 fastapi/typer#375
Some deprecated code was removed in pallets/click#2130 resulting in the failed import of
get_terminal_size
fromclick
. Per the recommendation in Click's release notes, we can import fromshutil
instead.get_terminal_size
can probably be dropped from Typer's interface in the future since it's been dropped from Click's, but I'll leave that decision to a future PR. This change is backwards compatible.See https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-0
Closes #377