-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade completion #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
- Coverage 99.96% 99.90% -0.06%
==========================================
Files 166 171 +5
Lines 2925 3313 +388
==========================================
+ Hits 2924 3310 +386
- Misses 1 3 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Upgrade completion.
Re-implement completion mixing ideas from
click-completion
and recent updates in Click. Fixing some issues in both and adding extra features.Add support for modern PowerShell including PowerShell Core (the latest version, installable on Linux). The current PowerShell support in
click-completion
is obsolete and doesn't work in recent versions of Windows, like Windows 10 😞 . But with this re-implementation it is now supported, including help texts. ✔️Now
click-completion
is not an optional dependency, it's all integrated into Typer. That also means Jinja and otherclick-completion
requirements are no longer needed.Add optional support for
shellingham
to auto-detect the shell to install completion.But without installing
shellingham
--show-completion
is now still available and becomes an optional argument that takes the shell for which to show completion. The same with--install-completion
.For it to work it's necessary to still monkeypatch Click, but now in a single place, a single function. It's all done automatically.
Shells supported: