Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add missing default_factory in Argument overloads #750

Merged
merged 1 commit into from
Mar 23, 2024
Merged

🐛 Add missing default_factory in Argument overloads #750

merged 1 commit into from
Mar 23, 2024

Conversation

m9810223
Copy link
Contributor

No description provided.

@svlandeg svlandeg added bug Something isn't working p2 labels Mar 19, 2024
svlandeg
svlandeg approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, nice catch!

These parameters are indeed missing in both overload declarations of Argument, and you've inserted them in the right spot. Thanks again!

@tiangolo tiangolo changed the title 🐛 missing default_factory in Argument overloads 🐛 Add missing default_factory in Argument overloads Mar 23, 2024
@tiangolo
Copy link
Member

tiangolo commented Mar 23, 2024 •
edited
Loading

Good catch, thanks @m9810223! 🚀

And thank you @svlandeg for the review! 🙇

This will be available in Typer 0.9.1 in the next few hours. 🚀

@tiangolo tiangolo merged commit 14ee8f1 into fastapi:master Mar 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
bug Something isn't working p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m9810223 @tiangolo @svlandeg