Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Add comments to document overload definitions in code #752

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

svlandeg
Copy link
Member

Merely a comment in code to help developers understand the difference between the different overload definitions (as it took me some time to figure out)

@svlandeg svlandeg added docs Improvements or additions to documentation p3 labels Mar 19, 2024
@tiangolo tiangolo changed the title Document overload definitions in code 💡 Add comments to document overload definitions in code Mar 23, 2024
@tiangolo tiangolo added internal and removed docs Improvements or additions to documentation labels Mar 23, 2024
@tiangolo tiangolo merged commit 5884e57 into fastapi:master Mar 23, 2024
18 checks passed
@tiangolo
Copy link
Member

Good point, thanks @svlandeg! 🚀 🍰

@svlandeg svlandeg deleted the feature/doc_overload branch March 23, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants