Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Update docs example for a Typer/Click group to make new subcommands explicit #755

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Mar 22, 2024

In the documentation, an example is given of a Typer app that includes a Click app. The example reads

// Notice we have both subcommands, top and hello

But for the user to actually see this, they should call main.py with --help specifically. I've updated the docs accordingly, and added a unit test to ensure that both commands are indeed shown in the help function.

@svlandeg svlandeg added docs Improvements or additions to documentation p3 labels Mar 22, 2024
Copy link

📝 Docs preview for commit 8b502ca at: https://63e0addf.typertiangolo.pages.dev

@tiangolo tiangolo changed the title Fix doc example for a Typer/Click group 📝 Update docs example for a Typer/Click group to make new subcommands explicit Mar 23, 2024
@tiangolo tiangolo merged commit 0440d9a into fastapi:master Mar 23, 2024
18 checks passed
@tiangolo
Copy link
Member

Great, thank you @svlandeg! 🍰

@svlandeg svlandeg deleted the fix/docs_example branch March 23, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation p3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants