Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add typer-slim package without extras, make typer include typer-slim[default] and integrate Typer CLI (typer command) into Typer #780

Merged
merged 25 commits into from
Mar 30, 2024

Conversation

tiangolo
Copy link
Member

✨ Add typer-slim package without extras, make typer include typer-slim[default] and integrate Typer CLI (typer command) into Typer

Copy link

📝 Docs preview for commit ab3f782 at: https://6bc4f9c4.typertiangolo.pages.dev

Copy link

📝 Docs preview for commit a4d2021 at: https://e47c807a.typertiangolo.pages.dev

Copy link

📝 Docs preview for commit 30ee488 at: https://e84f3168.typertiangolo.pages.dev

Copy link

📝 Docs preview for commit 3f056bf at: https://8d022b72.typertiangolo.pages.dev

Copy link

📝 Docs preview for commit 41dce92 at: https://5de276e5.typertiangolo.pages.dev

Copy link

📝 Docs preview for commit 89ecae0 at: https://1f48a0c9.typertiangolo.pages.dev

Copy link

📝 Docs preview for commit ab96545 at: https://6bf8f1af.typertiangolo.pages.dev

Copy link

📝 Docs preview for commit d6fd041 at: https://0c56739d.typertiangolo.pages.dev

Copy link

📝 Docs preview for commit 2967b16 at: https://c3d7506a.typertiangolo.pages.dev

Copy link

📝 Docs preview for commit 11ffbef at: https://8ada6028.typertiangolo.pages.dev

@tiangolo tiangolo added the feature New feature, enhancement or request label Mar 30, 2024
Copy link

📝 Docs preview for commit c73dedf at: https://1c870292.typertiangolo.pages.dev

@tiangolo tiangolo marked this pull request as ready for review March 30, 2024 02:08
@tiangolo tiangolo merged commit 7d5d6bb into master Mar 30, 2024
16 checks passed
@tiangolo tiangolo deleted the typer-slim branch March 30, 2024 02:09
name = "typer"
# pip install typer-slim: is only the Typer library, without extras
# pip install typer: is typer-slim[standard], with extras and typer-cli
name = "typer-slim"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you want to update the documentation to let users know that typer actually includes typer-slim and other packages?
This PR offuscates that and this change breaks users of FawltyDeps. We had declared typer as a dependency (-> failed), but it's now the project typer-slim the one that has a typer package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FCamborda! Could you open an discussion thread with this question? Because I worry that it might otherwise get lost on this merged PR 🙏

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svlandeg Sure! Let me know if this needs improvement: #786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature, enhancement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants