Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Add __init__.py files to fix test suite #809

Merged
merged 2 commits into from
May 2, 2024

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Apr 25, 2024

When running the test suite locally (both from the IDE as from Git Bash on Windows), I get a failure on tests/test_tutorial/test_subcommands/ both for test_tutorial001.py as well as test_tutorial003.py because the import items statement fails. The reason why it fails is because a __init__.py file is missing in the original docs_src module. Even though the CI here doesn't seem to be impacted, I think we might as well add the proper __init__.py files.

@svlandeg svlandeg added p3 repo / tests Involving the CI / test suite labels Apr 25, 2024
Copy link

📝 Docs preview for commit dd8d5f1 at: https://c732f7a3.typertiangolo.pages.dev

@svlandeg svlandeg changed the title ✅ Add __init__.py to fix test suite locally ✅ Add __init__.py to fix test suite locally Apr 25, 2024
@svlandeg
Copy link
Member Author

Even though the CI here doesn't seem to be impacted

In fact, perhaps we should consider extending the test suite to run on a grid, including windows-latest and macos-latest?

@svlandeg svlandeg changed the title ✅ Add __init__.py to fix test suite locally ✅ Add __init__.py files to fix test suite Apr 25, 2024
@tiangolo tiangolo changed the title ✅ Add __init__.py files to fix test suite ✅ Add __init__.py files to fix test suite May 2, 2024
@tiangolo tiangolo merged commit b9aa1db into fastapi:master May 2, 2024
18 checks passed
@tiangolo
Copy link
Member

tiangolo commented May 2, 2024

Awesome! 🚀

Yes, it would be great to run tests on Windows and MacOS, would you like to add that? 🙏

@svlandeg svlandeg deleted the feat/add_init branch May 3, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal p3 repo / tests Involving the CI / test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants